PCI: Don't leak memory if sysfs_create_bin_file() fails



If sysfs_create_bin_file() fails, pci_create_attr() leaks the struct
bin_attribute it allocated previously.

Free the struct bin_attribute if pci_create_attr() fails.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 9d88b93b

drivers/pci/pci-sysfs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1159,6 +1159,8 @@ static int pci_create_attr(struct pci_dev *pdev, int num, int write_combine)
		res_attr->size = pci_resource_len(pdev, num);
		res_attr->private = &pdev->resource[num];
		retval = sysfs_create_bin_file(&pdev->dev.kobj, res_attr);
		if (retval)
		kfree(res_attr);
		} else
		retval = -ENOMEM;