Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4176b7c authored by Nicolas Iooss's avatar Nicolas Iooss Committed by Linus Torvalds
Browse files

coredump: add __printf attribute to cn_*printf functions 



This allows detecting improper format string at build time, like:

  fs/coredump.c:225:5: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
       err = cn_printf(cn, "%ld", cprm->siginfo->si_signo);
       ^

As si_signo is always an int, the format should be %d here.

Signed-off-by: default avatarNicolas Iooss <nicolas.iooss_linux@m4x.org>
Acked-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5202efe5

fs/coredump.c

+7 −4
Original line number Diff line number Diff line
@@ -70,7 +70,8 @@ static int expand_corename(struct core_name *cn, int size) 
	return 0;

}



static int cn_vprintf(struct core_name *cn, const char *fmt, va_list arg)

static __printf(2, 0) int cn_vprintf(struct core_name *cn, const char *fmt,

				     va_list arg)

{

	int free, need;

	va_list arg_copy;
@@ -93,7 +94,7 @@ static int cn_vprintf(struct core_name *cn, const char *fmt, va_list arg) 
	return -ENOMEM;

}



static int cn_printf(struct core_name *cn, const char *fmt, ...)

static __printf(2, 3) int cn_printf(struct core_name *cn, const char *fmt, ...)

{

	va_list arg;

	int ret;
@@ -105,7 +106,8 @@ static int cn_printf(struct core_name *cn, const char *fmt, ...) 
	return ret;

}



static int cn_esc_printf(struct core_name *cn, const char *fmt, ...)

static __printf(2, 3)

int cn_esc_printf(struct core_name *cn, const char *fmt, ...)

{

	int cur = cn->used;

	va_list arg;
@@ -225,7 +227,8 @@ static int format_corename(struct core_name *cn, struct coredump_params *cprm) 
				break;

			/* signal that caused the coredump */

			case 's':

				err = cn_printf(cn, "%ld", cprm->siginfo->si_signo);

				err = cn_printf(cn, "%d",

						cprm->siginfo->si_signo);

				break;

			/* UNIX time of coredump */

			case 't': {