Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b41449d9 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier_set 



commit 61c59355e0154a938b28710dfa6c1d8be2ddcefa upstream.

_dev_ is being dereferenced before it is null checked, hence there
is a potential null pointer dereference.

Fix this by moving the pointer dereference after _dev_ has been null
checked.

Addresses-Coverity-ID: 1462020
Fixes: bb1b40c7cb86 ("usbnet: ipheth: prevent TX queue timeouts when device not ready")
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f5bca75d

drivers/net/usb/ipheth.c

+4 −1
Original line number Diff line number Diff line
@@ -290,12 +290,15 @@ static void ipheth_sndbulk_callback(struct urb *urb) 


static int ipheth_carrier_set(struct ipheth_device *dev)

{

	struct usb_device *udev = dev->udev;

	struct usb_device *udev;

	int retval;



	if (!dev)

		return 0;

	if (!dev->confirmed_pairing)

		return 0;



	udev = dev->udev;

	retval = usb_control_msg(udev,

			usb_rcvctrlpipe(udev, IPHETH_CTRL_ENDP),

			IPHETH_CMD_CARRIER_CHECK, /* request */