Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3e78cbc authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Kishon Vijay Abraham I
Browse files

phy: exynos-mipi-video: simplify check for coupled phy status 



There is no need to access regmap of coupled phy to check its state - such
information is already in the phy device itself, so use it directly. This
let us to avoid possible access to registers of the device in the disabled
power domain if the coupled phy is already disabled.

Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Acked-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 9bb86777

drivers/phy/phy-exynos-mipi-video.c

+1 −14
Original line number Diff line number Diff line
@@ -229,19 +229,6 @@ struct exynos_mipi_video_phy { 
	spinlock_t slock;

};



static inline int __is_running(const struct exynos_mipi_phy_desc *data,

			struct exynos_mipi_video_phy *state)

{

	u32 val;

	int ret;



	ret = regmap_read(state->regmaps[data->resetn_map], data->resetn_reg, &val);

	if (ret)

		return 0;



	return val & data->resetn_val;

}



static int __set_phy_state(const struct exynos_mipi_phy_desc *data,

			   struct exynos_mipi_video_phy *state, unsigned int on)

{
@@ -251,7 +238,7 @@ static int __set_phy_state(const struct exynos_mipi_phy_desc *data, 


	/* disable in PMU sysreg */

	if (!on && data->coupled_phy_id >= 0 &&

	    !__is_running(state->phys[data->coupled_phy_id].data, state)) {

	    state->phys[data->coupled_phy_id].phy->power_count == 0) {

		regmap_read(state->regmaps[data->enable_map], data->enable_reg,

			    &val);

		val &= ~data->enable_val;