Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b340e8a5 authored by Akinobu Mita's avatar Akinobu Mita Committed by Linus Torvalds
Browse files

auxdisplay: small cleanups 



- Use BUILD_BUG_ON for CFAG12864B_SIZE instead of runtime-check

- Use get_zeroed_page()

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: Miguel Ojeda Sandonis <maxextreme@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5bb49fcd

drivers/auxdisplay/cfag12864b.c

+2 −11
Original line number Diff line number Diff line
@@ -336,16 +336,9 @@ static int __init cfag12864b_init(void) 
			"ks0108 is not initialized\n");

		goto none;

	}

	BUILD_BUG_ON(PAGE_SIZE < CFAG12864B_SIZE);



	if (PAGE_SIZE < CFAG12864B_SIZE) {

		printk(KERN_ERR CFAG12864B_NAME ": ERROR: "

			"page size (%i) < cfag12864b size (%i)\n",

			(unsigned int)PAGE_SIZE, CFAG12864B_SIZE);

		ret = -ENOMEM;

		goto none;

	}



	cfag12864b_buffer = (unsigned char *) __get_free_page(GFP_KERNEL);

	cfag12864b_buffer = (unsigned char *) get_zeroed_page(GFP_KERNEL);

	if (cfag12864b_buffer == NULL) {

		printk(KERN_ERR CFAG12864B_NAME ": ERROR: "

			"can't get a free page\n");
@@ -367,8 +360,6 @@ static int __init cfag12864b_init(void) 
	if (cfag12864b_workqueue == NULL)

		goto cachealloced;



	memset(cfag12864b_buffer, 0, CFAG12864B_SIZE);



	cfag12864b_clear();

	cfag12864b_on();