Commit b30cdfc5 authored May 05, 2008 by Ivo van Doorn Committed by John W. Linville May 12, 2008

rt2x00: Clean up error handling of PCI queue DMA allocation.



When, for some reason, the rt2x00pci module fails to allocate DMA memory for
the queues, it tries to undo the complete initialization of the PCI device,
including freeing of the irq. This results in the following error in dmesg, as
the irq hadn't been requested yet:

[  78.123456] Trying to free already-free IRQ 17

Fix this by implementing proper error handling code, instead of just using the
full uninitialization function.

Signed-off-by: Gertjan van Wingerde <gwingerde@kpnplanet.nl>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent ed499983

drivers/net/wireless/rt2x00/rt2x00pci.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -314,13 +314,14 @@ int rt2x00pci_initialize(struct rt2x00_dev *rt2x00dev)
		if (status) {
		ERROR(rt2x00dev, "IRQ %d allocation failed (error %d).\n",
		pci_dev->irq, status);
		return status;
		goto exit;
		}

		return 0;

		exit:
		rt2x00pci_uninitialize(rt2x00dev);
		queue_for_each(rt2x00dev, queue)
		rt2x00pci_free_queue_dma(rt2x00dev, queue);

		return status;
		}