Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2c08299 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: do checkpoint for the renamed inode 



If an inode is renamed, it should be registered as file_lost_pino to conduct
checkpoint at f2fs_sync_file.
Otherwise, the inode cannot be recovered due to no dent_mark in the following
scenario.

Note that, this scenario is from xfstests/322.

1. create "a"
2. fsync "a"
3. rename "a" to "b"
4. fsync "b"
5. Sudden power-cut

After recovery is done, "b" should be seen.
However, the result shows "a", since the recovery procedure does not enter
recover_dentry due to no dent_mark.

The reason is like below.
- The nid of "a" is checkpointed during #2, f2fs_sync_file.
- The inode page for "b" produced by #3 is written without dent_mark by
sync_node_pages.

So, this patch fixes this bug by assinging file_lost_pino to the "a"'s inode.
If the pino is lost, f2fs_sync_file conducts checkpoint, and then recovers
the latest pino and its dentry information for further recovery.

Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent dd4d961f

fs/f2fs/namei.c

+4 −6
Original line number Diff line number Diff line
@@ -417,9 +417,6 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, 
		}



		f2fs_set_link(new_dir, new_entry, new_page, old_inode);

		down_write(&F2FS_I(old_inode)->i_sem);

		F2FS_I(old_inode)->i_pino = new_dir->i_ino;

		up_write(&F2FS_I(old_inode)->i_sem);



		new_inode->i_ctime = CURRENT_TIME;

		down_write(&F2FS_I(new_inode)->i_sem);
@@ -448,6 +445,10 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, 
		}

	}



	down_write(&F2FS_I(old_inode)->i_sem);

	file_lost_pino(old_inode);

	up_write(&F2FS_I(old_inode)->i_sem);



	old_inode->i_ctime = CURRENT_TIME;

	mark_inode_dirty(old_inode);
@@ -457,9 +458,6 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, 
		if (old_dir != new_dir) {

			f2fs_set_link(old_inode, old_dir_entry,

						old_dir_page, new_dir);

			down_write(&F2FS_I(old_inode)->i_sem);

			F2FS_I(old_inode)->i_pino = new_dir->i_ino;

			up_write(&F2FS_I(old_inode)->i_sem);

			update_inode_page(old_inode);

		} else {

			kunmap(old_dir_page);