Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b15e791d authored by Finn Thain's avatar Finn Thain Committed by Martin K. Petersen
Browse files

scsi: ncr5380: Improve target selection robustness 



Handle timeout or bus phase change errors that could occur when sending
the IDENTIFY message.

Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
Tested-by: default avatarOndrej Zary <linux@rainbow-software.org>
Tested-by: default avatarMichael Schmitz <schmitzmic@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4ab2a787

drivers/scsi/NCR5380.c

+9 −1
Original line number Diff line number Diff line
@@ -1165,8 +1165,16 @@ static struct scsi_cmnd *NCR5380_select(struct Scsi_Host *instance, 
	data = tmp;

	phase = PHASE_MSGOUT;

	NCR5380_transfer_pio(instance, &phase, &len, &data);

	if (len) {

		NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE);

		cmd->result = DID_ERROR << 16;

		complete_cmd(instance, cmd);

		dsprintk(NDEBUG_SELECTION, instance, "IDENTIFY message transfer failed\n");

		cmd = NULL;

		goto out;

	}



	dsprintk(NDEBUG_SELECTION, instance, "nexus established.\n");

	/* XXX need to handle errors here */



	hostdata->connected = cmd;

	hostdata->busy[cmd->device->id] |= 1 << cmd->device->lun;