Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0d436c7 authored by Anton Blanchard's avatar Anton Blanchard Committed by Benjamin Herrenschmidt
Browse files

powerpc: Fix a number of sparse warnings 



Address some of the trivial sparse warnings in arch/powerpc.

Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent a0a96ee9

arch/powerpc/kernel/legacy_serial.c

+1 −1
Original line number Diff line number Diff line
@@ -99,7 +99,7 @@ static int __init add_legacy_port(struct device_node *np, int want_index, 
		legacy_serial_count = index + 1;



	/* Check if there is a port who already claimed our slot */

	if (legacy_serial_infos[index].np != 0) {

	if (legacy_serial_infos[index].np != NULL) {

		/* if we still have some room, move it, else override */

		if (legacy_serial_count < MAX_LEGACY_SERIAL_PORTS) {

			printk(KERN_DEBUG "Moved legacy port %d -> %d\n",

arch/powerpc/kernel/pci-common.c

+2 −2
Original line number Diff line number Diff line
@@ -306,7 +306,7 @@ static struct resource *__pci_mmap_make_offset(struct pci_dev *dev, 
	unsigned long io_offset = 0;

	int i, res_bit;



	if (hose == 0)

	if (hose == NULL)

		return NULL;		/* should never happen */



	/* If memory, add on the PCI bridge address offset */
@@ -1578,7 +1578,7 @@ fake_pci_bus(struct pci_controller *hose, int busnr) 
{

	static struct pci_bus bus;



	if (hose == 0) {

	if (hose == NULL) {

		printk(KERN_ERR "Can't find hose for PCI bus %d!\n", busnr);

	}

	bus.number = busnr;

arch/powerpc/kernel/pci_64.c

+1 −1
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ int pcibios_unmap_io_space(struct pci_bus *bus) 
	hose = pci_bus_to_host(bus);



	/* Check if we have IOs allocated */

	if (hose->io_base_alloc == 0)

	if (hose->io_base_alloc == NULL)

		return 0;



	pr_debug("IO unmapping for PHB %s\n", hose->dn->full_name);

arch/powerpc/kernel/setup_64.c

+2 −2
Original line number Diff line number Diff line
@@ -325,7 +325,7 @@ static void __init initialize_cache_info(void) 
							 NULL);

			if (lsizep != NULL)

				lsize = *lsizep;

			if (sizep == 0 || lsizep == 0)

			if (sizep == NULL || lsizep == NULL)

				DBG("Argh, can't find dcache properties ! "

				    "sizep: %p, lsizep: %p\n", sizep, lsizep);
@@ -347,7 +347,7 @@ static void __init initialize_cache_info(void) 
							 NULL);

			if (lsizep != NULL)

				lsize = *lsizep;

			if (sizep == 0 || lsizep == 0)

			if (sizep == NULL || lsizep == NULL)

				DBG("Argh, can't find icache properties ! "

				    "sizep: %p, lsizep: %p\n", sizep, lsizep);

arch/powerpc/kernel/signal_64.c

+4 −4
Original line number Diff line number Diff line
@@ -346,13 +346,13 @@ static long restore_sigcontext(struct pt_regs *regs, sigset_t *set, int sig, 
	if (v_regs && !access_ok(VERIFY_READ, v_regs, 34 * sizeof(vector128)))

		return -EFAULT;

	/* Copy 33 vec registers (vr0..31 and vscr) from the stack */

	if (v_regs != 0 && (msr & MSR_VEC) != 0)

	if (v_regs != NULL && (msr & MSR_VEC) != 0)

		err |= __copy_from_user(current->thread.vr, v_regs,

					33 * sizeof(vector128));

	else if (current->thread.used_vr)

		memset(current->thread.vr, 0, 33 * sizeof(vector128));

	/* Always get VRSAVE back */

	if (v_regs != 0)

	if (v_regs != NULL)

		err |= __get_user(current->thread.vrsave, (u32 __user *)&v_regs[33]);

	else

		current->thread.vrsave = 0;
@@ -463,7 +463,7 @@ static long restore_tm_sigcontexts(struct pt_regs *regs, 
				    tm_v_regs, 34 * sizeof(vector128)))

		return -EFAULT;

	/* Copy 33 vec registers (vr0..31 and vscr) from the stack */

	if (v_regs != 0 && tm_v_regs != 0 && (msr & MSR_VEC) != 0) {

	if (v_regs != NULL && tm_v_regs != NULL && (msr & MSR_VEC) != 0) {

		err |= __copy_from_user(current->thread.vr, v_regs,

					33 * sizeof(vector128));

		err |= __copy_from_user(current->thread.transact_vr, tm_v_regs,
@@ -474,7 +474,7 @@ static long restore_tm_sigcontexts(struct pt_regs *regs, 
		memset(current->thread.transact_vr, 0, 33 * sizeof(vector128));

	}

	/* Always get VRSAVE back */

	if (v_regs != 0 && tm_v_regs != 0) {

	if (v_regs != NULL && tm_v_regs != NULL) {

		err |= __get_user(current->thread.vrsave,

				  (u32 __user *)&v_regs[33]);

		err |= __get_user(current->thread.transact_vrsave,