Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b08c9c31 authored by Loic Poulain's avatar Loic Poulain Committed by Greg Kroah-Hartman
Browse files

8250_core: Fix unwanted TX chars write 



On transmit-hold-register empty, serial8250_tx_chars
should be called only if we don't use DMA.
DMA has its own tx cycle.

Signed-off-by: default avatarLoic Poulain <loic.poulain@intel.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6a20dbd6

drivers/tty/serial/8250/8250_core.c

+1 −1
Original line number Diff line number Diff line
@@ -1520,7 +1520,7 @@ int serial8250_handle_irq(struct uart_port *port, unsigned int iir) 
			status = serial8250_rx_chars(up, status);

	}

	serial8250_modem_status(up);

	if (status & UART_LSR_THRE)

	if (!up->dma && (status & UART_LSR_THRE))

		serial8250_tx_chars(up);



	spin_unlock_irqrestore(&port->lock, flags);