Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b03388d6 authored by Sathya Perla's avatar Sathya Perla Committed by David S. Miller
Browse files

be2net: free tx buffers when completions never arrive 



be2net: free tx buffers when completions never arrive

In cases like when a pci device is disconnected on an error,
pending tx completions will never arrive. Unmap and free such
buffers in the tx cleanup path.

Signed-off-by: default avatarSathya Perla <sathyap@serverengines.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 72032fdb

drivers/net/benet/be_main.c

+12 −0
Original line number Diff line number Diff line
@@ -1128,6 +1128,9 @@ static void be_tx_compl_clean(struct be_adapter *adapter) 
	struct be_queue_info *txq = &adapter->tx_obj.q;

	struct be_eth_tx_compl *txcp;

	u16 end_idx, cmpl = 0, timeo = 0;

	struct sk_buff **sent_skbs = adapter->tx_obj.sent_skb_list;

	struct sk_buff *sent_skb;

	bool dummy_wrb;



	/* Wait for a max of 200ms for all the tx-completions to arrive. */

	do {
@@ -1151,6 +1154,15 @@ static void be_tx_compl_clean(struct be_adapter *adapter) 
	if (atomic_read(&txq->used))

		dev_err(&adapter->pdev->dev, "%d pending tx-completions\n",

			atomic_read(&txq->used));



	/* free posted tx for which compls will never arrive */

	while (atomic_read(&txq->used)) {

		sent_skb = sent_skbs[txq->tail];

		end_idx = txq->tail;

		index_adv(&end_idx,

			wrb_cnt_for_skb(sent_skb, &dummy_wrb) - 1, txq->len);

		be_tx_compl_process(adapter, end_idx);

	}

}



static void be_mcc_queues_destroy(struct be_adapter *adapter)