Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit affad682 authored by Karthik Anantha Ram's avatar Karthik Anantha Ram Committed by Gerrit - the friendly Code Review server
Browse files

msm: camera: cpas: Improve logging capability 



Currently the logs print only the cpas/bus client idx,
this change logs the name of the client as well which enhances
debugging capabilities.

Change-Id: I8c0cb23fc846a5b8f5801c78024d1c76559dc48e
Signed-off-by: default avatarKarthik Anantha Ram <kartanan@codeaurora.org>
parent b8d336f9

drivers/media/platform/msm/camera/cam_cpas/cam_cpas_hw.c

+78 −41
Original line number Diff line number Diff line
@@ -77,8 +77,8 @@ static int cam_cpas_util_vote_bus_client_level( 
	if (level == bus_client->curr_vote_level)

		return 0;



	CAM_DBG(CAM_CPAS, "Bus client[%d] index[%d]", bus_client->client_id,

		level);

	CAM_DBG(CAM_CPAS, "Bus client=[%d][%s] index[%d]",

		bus_client->client_id, bus_client->name, level);

	msm_bus_scale_client_update_request(bus_client->client_id, level);

	bus_client->curr_vote_level = level;
@@ -147,8 +147,8 @@ static int cam_cpas_util_vote_bus_client_bw( 
	path->vectors[0].ab = ab;

	path->vectors[0].ib = ib;



	CAM_DBG(CAM_CPAS, "Bus client[%d] :ab[%llu] ib[%llu], index[%d]",

		bus_client->client_id, ab, ib, idx);

	CAM_DBG(CAM_CPAS, "Bus client=[%d][%s] :ab[%llu] ib[%llu], index[%d]",

		bus_client->client_id, bus_client->name, ab, ib, idx);

	msm_bus_scale_client_update_request(bus_client->client_id, idx);



	return 0;
@@ -203,10 +203,12 @@ static int cam_cpas_util_register_bus_client( 
	bus_client->num_paths = pdata->usecase[0].num_paths;

	bus_client->curr_vote_level = 0;

	bus_client->valid = true;

	bus_client->name = pdata->name;

	mutex_init(&bus_client->lock);



	CAM_DBG(CAM_CPAS, "Bus Client : src=%d, dst=%d, bus_client=%d",

		bus_client->src, bus_client->dst, bus_client->client_id);

	CAM_DBG(CAM_CPAS, "Bus Client=[%d][%s] : src=%d, dst=%d",

		bus_client->client_id, bus_client->name,

		bus_client->src, bus_client->dst);



	return 0;

fail_unregister_client:
@@ -458,6 +460,7 @@ static int cam_cpas_hw_reg_write(struct cam_hw_info *cpas_hw, 
{

	struct cam_hw_soc_info *soc_info = &cpas_hw->soc_info;

	struct cam_cpas *cpas_core = (struct cam_cpas *) cpas_hw->core_info;

	struct cam_cpas_client *cpas_client = NULL;

	int reg_base_index = cpas_core->regbase_index[reg_base];

	uint32_t client_indx = CAM_CPAS_GET_CLIENT_IDX(client_handle);

	int rc = 0;
@@ -473,9 +476,12 @@ static int cam_cpas_hw_reg_write(struct cam_hw_info *cpas_hw, 
		return -EINVAL;



	mutex_lock(&cpas_core->client_mutex[client_indx]);

	cpas_client = cpas_core->cpas_client[client_indx];



	if (!CAM_CPAS_CLIENT_STARTED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "client has not started%d", client_indx);

		CAM_ERR(CAM_CPAS, "client=[%d][%s][%d] has not started",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index);

		rc = -EPERM;

		goto unlock_client;

	}
@@ -498,6 +504,7 @@ static int cam_cpas_hw_reg_read(struct cam_hw_info *cpas_hw, 
{

	struct cam_hw_soc_info *soc_info = &cpas_hw->soc_info;

	struct cam_cpas *cpas_core = (struct cam_cpas *) cpas_hw->core_info;

	struct cam_cpas_client *cpas_client = NULL;

	int reg_base_index = cpas_core->regbase_index[reg_base];

	uint32_t reg_value;

	uint32_t client_indx = CAM_CPAS_GET_CLIENT_IDX(client_handle);
@@ -518,9 +525,12 @@ static int cam_cpas_hw_reg_read(struct cam_hw_info *cpas_hw, 


	mutex_lock(&cpas_hw->hw_mutex);

	mutex_lock(&cpas_core->client_mutex[client_indx]);

	cpas_client = cpas_core->cpas_client[client_indx];



	if (!CAM_CPAS_CLIENT_STARTED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "client has not started%d", client_indx);

		CAM_ERR(CAM_CPAS, "client=[%d][%s][%d] has not started",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index);

		rc = -EPERM;

		goto unlock_client;

	}
@@ -706,6 +716,7 @@ static int cam_cpas_hw_update_axi_vote(struct cam_hw_info *cpas_hw, 
{

	struct cam_axi_vote axi_vote;

	struct cam_cpas *cpas_core = (struct cam_cpas *) cpas_hw->core_info;

	struct cam_cpas_client *cpas_client = NULL;

	uint32_t client_indx = CAM_CPAS_GET_CLIENT_IDX(client_handle);

	int rc = 0;
@@ -730,16 +741,20 @@ static int cam_cpas_hw_update_axi_vote(struct cam_hw_info *cpas_hw, 


	mutex_lock(&cpas_hw->hw_mutex);

	mutex_lock(&cpas_core->client_mutex[client_indx]);

	cpas_client = cpas_core->cpas_client[client_indx];



	if (!CAM_CPAS_CLIENT_STARTED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "client has not started %d", client_indx);

		CAM_ERR(CAM_CPAS, "client=[%d][%s][%d] has not started",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index);

		rc = -EPERM;

		goto unlock_client;

	}



	CAM_DBG(CAM_CPAS,

		"Client[%d] Requested compressed[%llu], uncompressed[%llu]",

		client_indx, axi_vote.compressed_bw,

		"Client=[%d][%s][%d] Requested compressed[%llu], uncompressed[%llu]",

		client_indx, cpas_client->data.identifier,

		cpas_client->data.cell_index, axi_vote.compressed_bw,

		axi_vote.uncompressed_bw);



	rc = cam_cpas_util_apply_client_axi_vote(cpas_hw,
@@ -820,7 +835,8 @@ static int cam_cpas_util_apply_client_ahb_vote(struct cam_hw_info *cpas_hw, 
	mutex_lock(&ahb_bus_client->lock);

	cpas_client->ahb_level = required_level;



	CAM_DBG(CAM_CPAS, "Clients required level[%d], curr_level[%d]",

	CAM_DBG(CAM_CPAS, "Client=[%d][%s] required level[%d], curr_level[%d]",

		ahb_bus_client->client_id, ahb_bus_client->name,

		required_level, ahb_bus_client->curr_vote_level);



	if (required_level == ahb_bus_client->curr_vote_level)
@@ -864,6 +880,7 @@ static int cam_cpas_hw_update_ahb_vote(struct cam_hw_info *cpas_hw, 
{

	struct cam_ahb_vote ahb_vote;

	struct cam_cpas *cpas_core = (struct cam_cpas *) cpas_hw->core_info;

	struct cam_cpas_client *cpas_client = NULL;

	uint32_t client_indx = CAM_CPAS_GET_CLIENT_IDX(client_handle);

	int rc = 0;
@@ -886,17 +903,21 @@ static int cam_cpas_hw_update_ahb_vote(struct cam_hw_info *cpas_hw, 


	mutex_lock(&cpas_hw->hw_mutex);

	mutex_lock(&cpas_core->client_mutex[client_indx]);

	cpas_client = cpas_core->cpas_client[client_indx];



	if (!CAM_CPAS_CLIENT_STARTED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "client has not started %d", client_indx);

		CAM_ERR(CAM_CPAS, "client=[%d][%s][%d] has not started",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index);

		rc = -EPERM;

		goto unlock_client;

	}



	CAM_DBG(CAM_CPAS,

		"client[%d] : type[%d], level[%d], freq[%ld], applied[%d]",

		client_indx, ahb_vote.type, ahb_vote.vote.level,

		ahb_vote.vote.freq,

		"client=[%d][%s][%d] : type[%d], level[%d], freq[%ld], applied[%d]",

		client_indx, cpas_client->data.identifier,

		cpas_client->data.cell_index, ahb_vote.type,

		ahb_vote.vote.level, ahb_vote.vote.freq,

		cpas_core->cpas_client[client_indx]->ahb_level);



	rc = cam_cpas_util_apply_client_ahb_vote(cpas_hw,
@@ -958,32 +979,37 @@ static int cam_cpas_hw_start(void *hw_priv, void *start_args, 


	mutex_lock(&cpas_hw->hw_mutex);

	mutex_lock(&cpas_core->client_mutex[client_indx]);

	cpas_client = cpas_core->cpas_client[client_indx];



	if (!CAM_CPAS_CLIENT_REGISTERED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "client is not registered %d", client_indx);

		CAM_ERR(CAM_CPAS, "client=[%d] is not registered",

			client_indx);

		rc = -EPERM;

		goto done;

	}



	if (CAM_CPAS_CLIENT_STARTED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "Client %d is in start state", client_indx);

		CAM_ERR(CAM_CPAS, "client=[%d][%s][%d] is in start state",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index);

		rc = -EPERM;

		goto done;

	}



	cpas_client = cpas_core->cpas_client[client_indx];



	CAM_DBG(CAM_CPAS, "AHB :client[%d] type[%d], level[%d], applied[%d]",

		client_indx, ahb_vote->type, ahb_vote->vote.level,

		cpas_client->ahb_level);

	CAM_DBG(CAM_CPAS,

		"AHB :client=[%d][%s][%d] type[%d], level[%d], applied[%d]",

		client_indx, cpas_client->data.identifier,

		cpas_client->data.cell_index,

		ahb_vote->type, ahb_vote->vote.level, cpas_client->ahb_level);

	rc = cam_cpas_util_apply_client_ahb_vote(cpas_hw, cpas_client,

		ahb_vote, &applied_level);

	if (rc)

		goto done;



	CAM_DBG(CAM_CPAS,

		"AXI client[%d] compressed_bw[%llu], uncompressed_bw[%llu]",

		client_indx, axi_vote->compressed_bw,

		"AXI client=[%d][%s][%d] compressed_bw[%llu], uncompressed_bw[%llu]",

		client_indx, cpas_client->data.identifier,

		cpas_client->data.cell_index, axi_vote->compressed_bw,

		axi_vote->uncompressed_bw);

	rc = cam_cpas_util_apply_client_axi_vote(cpas_hw,

		cpas_client, axi_vote);
@@ -1020,9 +1046,9 @@ static int cam_cpas_hw_start(void *hw_priv, void *start_args, 
	cpas_client->started = true;

	cpas_core->streamon_clients++;



	CAM_DBG(CAM_CPAS, "client=%s, streamon_clients=%d",

		soc_private->client_name[client_indx],

		cpas_core->streamon_clients);

	CAM_DBG(CAM_CPAS, "client=[%d][%s][%d] streamon_clients=%d",

		client_indx, cpas_client->data.identifier,

		cpas_client->data.cell_index, cpas_core->streamon_clients);

done:

	mutex_unlock(&cpas_core->client_mutex[client_indx]);

	mutex_unlock(&cpas_hw->hw_mutex);
@@ -1072,18 +1098,20 @@ static int cam_cpas_hw_stop(void *hw_priv, void *stop_args, 


	mutex_lock(&cpas_hw->hw_mutex);

	mutex_lock(&cpas_core->client_mutex[client_indx]);

	cpas_client = cpas_core->cpas_client[client_indx];



	CAM_DBG(CAM_CPAS, "client=%s, streamon_clients=%d",

		soc_private->client_name[client_indx],

		cpas_core->streamon_clients);

	CAM_DBG(CAM_CPAS, "Client=[%d][%s][%d] streamon_clients=%d",

		client_indx, cpas_client->data.identifier,

		cpas_client->data.cell_index, cpas_core->streamon_clients);



	if (!CAM_CPAS_CLIENT_STARTED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "Client %d is not started", client_indx);

		CAM_ERR(CAM_CPAS, "Client=[%d][%s][%d] is not started",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index);

		rc = -EPERM;

		goto done;

	}



	cpas_client = cpas_core->cpas_client[client_indx];

	cpas_client->started = false;

	cpas_core->streamon_clients--;
@@ -1217,8 +1245,9 @@ static int cam_cpas_hw_register_client(struct cam_hw_info *cpas_hw, 
		cpas_client, client_indx);

	if (rc) {

		CAM_ERR(CAM_CPAS,

			"axi_port_insert failed client_indx=%d, rc=%d",

			client_indx, rc);

			"axi_port_insert failed Client=[%d][%s][%d], rc=%d",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index, rc);

		kfree(cpas_client);

		mutex_unlock(&cpas_hw->hw_mutex);

		return -EINVAL;
@@ -1233,8 +1262,9 @@ static int cam_cpas_hw_register_client(struct cam_hw_info *cpas_hw, 


	mutex_unlock(&cpas_hw->hw_mutex);



	CAM_DBG(CAM_CPAS, "client_indx=%d, registered_clients=%d",

		client_indx, cpas_core->registered_clients);

	CAM_DBG(CAM_CPAS, "client=[%d][%s][%d], registered_clients=%d",

		client_indx, cpas_client->data.identifier,

		cpas_client->data.cell_index, cpas_core->registered_clients);



	return 0;

}
@@ -1243,6 +1273,7 @@ static int cam_cpas_hw_unregister_client(struct cam_hw_info *cpas_hw, 
	uint32_t client_handle)

{

	struct cam_cpas *cpas_core = (struct cam_cpas *) cpas_hw->core_info;

	struct cam_cpas_client *cpas_client = NULL;

	uint32_t client_indx = CAM_CPAS_GET_CLIENT_IDX(client_handle);

	int rc = 0;
@@ -1251,15 +1282,20 @@ static int cam_cpas_hw_unregister_client(struct cam_hw_info *cpas_hw, 


	mutex_lock(&cpas_hw->hw_mutex);

	mutex_lock(&cpas_core->client_mutex[client_indx]);

	cpas_client = cpas_core->cpas_client[client_indx];



	if (!CAM_CPAS_CLIENT_REGISTERED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "client not registered %d", client_indx);

		CAM_ERR(CAM_CPAS, "Client=[%d][%s][%d] not registered",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index);

		rc = -EPERM;

		goto done;

	}



	if (CAM_CPAS_CLIENT_STARTED(cpas_core, client_indx)) {

		CAM_ERR(CAM_CPAS, "Client %d is not stopped", client_indx);

		CAM_ERR(CAM_CPAS, "Client=[%d][%s][%d] is not stopped",

			client_indx, cpas_client->data.identifier,

			cpas_client->data.cell_index);

		rc = -EPERM;

		goto done;

	}
@@ -1267,8 +1303,9 @@ static int cam_cpas_hw_unregister_client(struct cam_hw_info *cpas_hw, 
	cam_cpas_util_remove_client_from_axi_port(

		cpas_core->cpas_client[client_indx]);



	CAM_DBG(CAM_CPAS, "client_indx=%d, registered_clients=%d",

		client_indx, cpas_core->registered_clients);

	CAM_DBG(CAM_CPAS, "client=[%d][%s][%d], registered_clients=%d",

		client_indx, cpas_client->data.identifier,

		cpas_client->data.cell_index, cpas_core->registered_clients);



	kfree(cpas_core->cpas_client[client_indx]);

	cpas_core->cpas_client[client_indx] = NULL;

drivers/media/platform/msm/camera/cam_cpas/cam_cpas_hw.h

+2 −0
Original line number Diff line number Diff line
@@ -123,6 +123,7 @@ struct cam_cpas_client { 
 * @dyn_vote: Whether dynamic voting enabled

 * @lock: Mutex lock used while voting on this client

 * @valid: Whether bus client is valid

 * @name: Name of the bus client

 *

 */

struct cam_cpas_bus_client {
@@ -136,6 +137,7 @@ struct cam_cpas_bus_client { 
	bool dyn_vote;

	struct mutex lock;

	bool valid;

	const char *name;

};



/**