Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afccf6f3 authored by Emil Tantilov's avatar Emil Tantilov Committed by Greg Kroah-Hartman
Browse files

ixgbe: fix use of uninitialized padding 




[ Upstream commit dcfd6b839c998bc9838e2a47f44f37afbdf3099c ]

This patch is resolving Coverity hits where padding in a structure could
be used uninitialized.

- Initialize fwd_cmd.pad/2 before ixgbe_calculate_checksum()

- Initialize buffer.pad2/3 before ixgbe_hic_unlocked()

Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d1f13dca

drivers/net/ethernet/intel/ixgbe/ixgbe_common.c

+2 −2
Original line number Diff line number Diff line
@@ -3781,10 +3781,10 @@ s32 ixgbe_set_fw_drv_ver_generic(struct ixgbe_hw *hw, u8 maj, u8 min, 
	fw_cmd.ver_build = build;

	fw_cmd.ver_sub = sub;

	fw_cmd.hdr.checksum = 0;

	fw_cmd.hdr.checksum = ixgbe_calculate_checksum((u8 *)&fw_cmd,

				(FW_CEM_HDR_LEN + fw_cmd.hdr.buf_len));

	fw_cmd.pad = 0;

	fw_cmd.pad2 = 0;

	fw_cmd.hdr.checksum = ixgbe_calculate_checksum((u8 *)&fw_cmd,

				(FW_CEM_HDR_LEN + fw_cmd.hdr.buf_len));



	for (i = 0; i <= FW_CEM_MAX_RETRIES; i++) {

		ret_val = ixgbe_host_interface_command(hw, &fw_cmd,

drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c

+2 −0
Original line number Diff line number Diff line
@@ -900,6 +900,8 @@ static s32 ixgbe_read_ee_hostif_buffer_X550(struct ixgbe_hw *hw, 
		/* convert offset from words to bytes */

		buffer.address = cpu_to_be32((offset + current_word) * 2);

		buffer.length = cpu_to_be16(words_to_read * 2);

		buffer.pad2 = 0;

		buffer.pad3 = 0;



		status = ixgbe_hic_unlocked(hw, (u32 *)&buffer, sizeof(buffer),

					    IXGBE_HI_COMMAND_TIMEOUT);