Commit afadc440 authored Jan 18, 2018 by weiyongjun (A) Committed by Greg Kroah-Hartman Apr 26, 2018

mac80211_hwsim: fix possible memory leak in hwsim_new_radio_nl()




[ Upstream commit 0ddcff49b672239dda94d70d0fcf50317a9f4b51 ]

'hwname' is malloced in hwsim_new_radio_nl() and should be freed
before leaving from the error handling cases, otherwise it will cause
memory leak.

Fixes: ff4dd73d ("mac80211_hwsim: check HWSIM_ATTR_RADIO_NAME length")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 18004e6f

drivers/net/wireless/mac80211_hwsim.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -3153,8 +3153,10 @@ static int hwsim_new_radio_nl(struct sk_buff msg, struct genl_info info)
		if (info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]) {
		u32 idx = nla_get_u32(info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]);

		if (idx >= ARRAY_SIZE(hwsim_world_regdom_custom))
		if (idx >= ARRAY_SIZE(hwsim_world_regdom_custom)) {
		kfree(hwname);
		return -EINVAL;
		}
		param.regd = hwsim_world_regdom_custom[idx];
		}