Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aeb922df authored by Naga Irrinki's avatar Naga Irrinki Committed by Doug Ledford
Browse files

RDMA/ocrdma: Check resource ids received in Async CQE 



Some versions of the FW sends wrong QP or CQ IDs in the
Async CQE. Adding a check to see whether qp or cq structures
associated with the CQE is valid.

Signed-off-by: default avatarDevesh Sharma <devesh.sharma@avagotech.com>
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@avagotech.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent fb16d8c4

drivers/infiniband/hw/ocrdma/ocrdma_hw.c

+26 −4
Original line number Diff line number Diff line
@@ -678,11 +678,33 @@ static void ocrdma_dispatch_ibevent(struct ocrdma_dev *dev, 
	int dev_event = 0;

	int type = (cqe->valid_ae_event & OCRDMA_AE_MCQE_EVENT_TYPE_MASK) >>

	    OCRDMA_AE_MCQE_EVENT_TYPE_SHIFT;

	u16 qpid = cqe->qpvalid_qpid & OCRDMA_AE_MCQE_QPID_MASK;

	u16 cqid = cqe->cqvalid_cqid & OCRDMA_AE_MCQE_CQID_MASK;



	if (cqe->qpvalid_qpid & OCRDMA_AE_MCQE_QPVALID)

		qp = dev->qp_tbl[cqe->qpvalid_qpid & OCRDMA_AE_MCQE_QPID_MASK];

	if (cqe->cqvalid_cqid & OCRDMA_AE_MCQE_CQVALID)

		cq = dev->cq_tbl[cqe->cqvalid_cqid & OCRDMA_AE_MCQE_CQID_MASK];

	/*

	 * Some FW version returns wrong qp or cq ids in CQEs.

	 * Checking whether the IDs are valid

	 */



	if (cqe->qpvalid_qpid & OCRDMA_AE_MCQE_QPVALID) {

		if (qpid < dev->attr.max_qp)

			qp = dev->qp_tbl[qpid];

		if (qp == NULL) {

			pr_err("ocrdma%d:Async event - qpid %u is not valid\n",

			       dev->id, qpid);

			return;

		}

	}



	if (cqe->cqvalid_cqid & OCRDMA_AE_MCQE_CQVALID) {

		if (cqid < dev->attr.max_cq)

			cq = dev->cq_tbl[cqid];

		if (cq == NULL) {

			pr_err("ocrdma%d:Async event - cqid %u is not valid\n",

			       dev->id, cqid);

			return;

		}

	}



	memset(&ib_evt, 0, sizeof(ib_evt));