Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae70a7bb authored by Akinobu Mita's avatar Akinobu Mita Committed by Linus Torvalds
Browse files

metag: use for_each_sg()



This replaces the plain loop over the sglist array with for_each_sg()
macro which consists of sg_next() function calls.  Since metag doesn't
select ARCH_HAS_SG_CHAIN, it is not necessary to use for_each_sg() in
order to loop over each sg element.  But this can help find problems
with drivers that do not properly initialize their sg tables when
CONFIG_DEBUG_SG is enabled.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: James Hogan <james.hogan@imgtec.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e3d8238d
Loading
Loading
Loading
Loading
+9 −5
Original line number Diff line number Diff line
@@ -134,20 +134,24 @@ dma_sync_single_range_for_device(struct device *dev, dma_addr_t dma_handle,
}

static inline void
dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nelems,
dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sglist, int nelems,
		    enum dma_data_direction direction)
{
	int i;
	for (i = 0; i < nelems; i++, sg++)
	struct scatterlist *sg;

	for_each_sg(sglist, sg, nelems, i)
		dma_sync_for_cpu(sg_virt(sg), sg->length, direction);
}

static inline void
dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, int nelems,
		       enum dma_data_direction direction)
dma_sync_sg_for_device(struct device *dev, struct scatterlist *sglist,
		       int nelems, enum dma_data_direction direction)
{
	int i;
	for (i = 0; i < nelems; i++, sg++)
	struct scatterlist *sg;

	for_each_sg(sglist, sg, nelems, i)
		dma_sync_for_device(sg_virt(sg), sg->length, direction);
}