Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae57a856 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Linus Torvalds
Browse files

[PATCH] kobject: quiet errors in kobject_add 



People don't like released kernels yelling at them, no matter how real the
error might be.  So only report it if CONFIG_KOBJECT_DEBUG is enabled.

Sent on request of Andrew Morton.

(akpm: should bring this back post-2.6.17)

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent b3969e58

lib/kobject.c

+3 −3
Original line number Diff line number Diff line
@@ -198,14 +198,14 @@ int kobject_add(struct kobject * kobj) 


		/* be noisy on error issues */

		if (error == -EEXIST)

			printk("kobject_add failed for %s with -EEXIST, "

			pr_debug("kobject_add failed for %s with -EEXIST, "

			       "don't try to register things with the "

			       "same name in the same directory.\n",

			       kobject_name(kobj));

		else

			printk("kobject_add failed for %s (%d)\n",

			pr_debug("kobject_add failed for %s (%d)\n",

			       kobject_name(kobj), error);

		dump_stack();

		/* dump_stack(); */

	}



	return error;