Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae374a30 authored by James Smart's avatar James Smart Committed by James Bottomley
Browse files

lpfc: Fix scsi task management error message. 



TMF's were getting error messages on FCP_RSP errors (underrun). Underruns
aren't meaningful in the scenario. Change the error message to filter out
these response check errors, and don't unconditionally mark the cmd as
in error.

Signed-off-by: default avatarDick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: default avatarJames Smart <james.smart@avagotech.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent 16f3b48d

drivers/scsi/lpfc/lpfc_scsi.c

+10 −8
Original line number Diff line number Diff line
@@ -5011,11 +5011,14 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct lpfc_rport_data *rdata, 
					  iocbq, iocbqrsp, lpfc_cmd->timeout);

	if ((status != IOCB_SUCCESS) ||

	    (iocbqrsp->iocb.ulpStatus != IOSTAT_SUCCESS)) {

		if (status != IOCB_SUCCESS ||

		    iocbqrsp->iocb.ulpStatus != IOSTAT_FCP_RSP_ERROR)

			lpfc_printf_vlog(vport, KERN_ERR, LOG_FCP,

			 "0727 TMF %s to TGT %d LUN %llu failed (%d, %d) "

			 "iocb_flag x%x\n",

					 "0727 TMF %s to TGT %d LUN %llu "

					 "failed (%d, %d) iocb_flag x%x\n",

					 lpfc_taskmgmt_name(task_mgmt_cmd),

			 tgt_id, lun_id, iocbqrsp->iocb.ulpStatus,

					 tgt_id, lun_id,

					 iocbqrsp->iocb.ulpStatus,

					 iocbqrsp->iocb.un.ulpWord[4],

					 iocbq->iocb_flag);

		/* if ulpStatus != IOCB_SUCCESS, then status == IOCB_SUCCESS */
@@ -5031,7 +5034,6 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct lpfc_rport_data *rdata, 
		} else {

			ret = FAILED;

		}

		lpfc_cmd->status = IOSTAT_DRIVER_REJECT;

	} else

		ret = SUCCESS;