Commit ae35822a authored Mar 18, 2019 by Julian Wiedmann Committed by Greg Kroah-Hartman May 04, 2019

s390/qeth: fix race when initializing the IP address table



[ Upstream commit 7221b727f0079a32aca91f657141e1de564d4b97 ]

The ucast IP table is utilized by some of the L3-specific sysfs attributes
that qeth_l3_create_device_attributes() provides. So initialize the table
_before_ registering the attributes.

Fixes: ebccc739 ("s390/qeth: add missing hash table initializations")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>

parent 208deceb

drivers/s390/net/qeth_l3_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -3022,12 +3022,14 @@ static int qeth_l3_probe_device(struct ccwgroup_device *gdev)
		struct qeth_card *card = dev_get_drvdata(&gdev->dev);
		int rc;

		hash_init(card->ip_htable);

		if (gdev->dev.type == &qeth_generic_devtype) {
		rc = qeth_l3_create_device_attributes(&gdev->dev);
		if (rc)
		return rc;
		}
		hash_init(card->ip_htable);

		hash_init(card->ip_mc_htable);
		card->options.layer2 = 0;
		card->info.hwtrap = 0;