Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acec3630 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mauro Carvalho Chehab
Browse files

[media] s3c-camif: fix arguments position in a function call 



Fix the position of arguments so camif->colorfx_cb, camif->colorfx_cr
are passed in proper order to the camif_hw_set_effect() function.

Addresses-Coverity-ID: 1248800
Addresses-Coverity-ID: 1269141

[s.nawrocki@samsung.com: edited commit message ]
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 3966f5ce

drivers/media/platform/s3c-camif/camif-capture.c

+2 −2
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp) 
	camif_hw_set_test_pattern(camif, camif->test_pattern);

	if (variant->has_img_effect)

		camif_hw_set_effect(camif, camif->colorfx,

				camif->colorfx_cb, camif->colorfx_cr);

				camif->colorfx_cr, camif->colorfx_cb);

	if (variant->ip_revision == S3C6410_CAMIF_IP_REV)

		camif_hw_set_input_path(vp);

	camif_cfg_video_path(vp);
@@ -364,7 +364,7 @@ irqreturn_t s3c_camif_irq_handler(int irq, void *priv) 
		camif_hw_set_test_pattern(camif, camif->test_pattern);

		if (camif->variant->has_img_effect)

			camif_hw_set_effect(camif, camif->colorfx,

				    camif->colorfx_cb, camif->colorfx_cr);

				    camif->colorfx_cr, camif->colorfx_cb);

		vp->state &= ~ST_VP_CONFIG;

	}

unlock: