Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab88c8dc authored by Doug Anderson's avatar Doug Anderson Committed by Greg Kroah-Hartman
Browse files

serial: samsung: don't check config for every character 



The s3c24xx_serial_console_putchar() is _only_ ever used by
s3c24xx_serial_console_write() and is called in a loop (indirectly
through uart_console_write()).  There's no reason to call
s3c24xx_port_configured() for every iteration through the loop.  Move
it outside the loop.

Signed-off-by: default avatarDoug Anderson <dianders@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bb7f09ba

drivers/tty/serial/samsung.c

+6 −5
Original line number Diff line number Diff line
@@ -1464,11 +1464,6 @@ static void 
s3c24xx_serial_console_putchar(struct uart_port *port, int ch)

{

	unsigned int ufcon = rd_regl(port, S3C2410_UFCON);

	unsigned int ucon = rd_regl(port, S3C2410_UCON);



	/* not possible to xmit on unconfigured port */

	if (!s3c24xx_port_configured(ucon))

		return;



	while (!s3c24xx_serial_console_txrdy(port, ufcon))

		barrier();
@@ -1479,6 +1474,12 @@ static void 
s3c24xx_serial_console_write(struct console *co, const char *s,

			     unsigned int count)

{

	unsigned int ucon = rd_regl(cons_uart, S3C2410_UCON);



	/* not possible to xmit on unconfigured port */

	if (!s3c24xx_port_configured(ucon))

		return;



	uart_console_write(cons_uart, s, count, s3c24xx_serial_console_putchar);

}