Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab2e8f7d authored by Dan Williams's avatar Dan Williams
Browse files

isci: merge remote_device substates into a single state machine



A substate is just a state, so uplevel the smp and stp device substates.
Three tricks at work here:

1/ scic_sds_remote_device_ready_state_enter: needs to know the the device type
   so it can immediately transition to a stp or smp ready substate.

2/ scic_sds_remote_device_ready_state_exit: needs to know the device type. In
   the ssp case the device is no longer ready, in the stp, and smp case we have
   simply exited to a ready "substate".

3/ scic_sds_remote_device_resume_complete_handler: The one location
   where we directly check the current state against
   SCI_BASE_REMOTE_DEVICE_STATE_READY needed to comprehend the possible ready
   substates.

Reported-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent be2f41c6
Loading
Loading
Loading
Loading
+0 −2
Original line number Diff line number Diff line
@@ -7,8 +7,6 @@ obj-$(CONFIG_SCSI_ISCI) += isci.o
isci-objs := init.o phy.o request.o sata.o \
	     remote_device.o port.o timers.o \
	     host.o task.o probe_roms.o \
	     stp_remote_device.o \
	     smp_remote_device.o \
	     remote_node_context.o \
	     remote_node_table.o \
	     core/scic_sds_controller.o  \
+906 −334

File changed.

Preview size limit exceeded, changes collapsed.

+34 −174
Original line number Diff line number Diff line
@@ -68,9 +68,7 @@ enum scic_remote_device_not_ready_reason_code {
	SCIC_REMOTE_DEVICE_NOT_READY_SATA_REQUEST_STARTED,
	SCIC_REMOTE_DEVICE_NOT_READY_SATA_SDB_ERROR_FIS_RECEIVED,
	SCIC_REMOTE_DEVICE_NOT_READY_SMP_REQUEST_STARTED,

	SCIC_REMOTE_DEVICE_NOT_READY_REASON_CODE_MAX

};

struct scic_sds_remote_device {
@@ -131,19 +129,6 @@ struct scic_sds_remote_device {
	 */
	u32 not_ready_reason;

	/**
	 * This field is true if this remote device has an initialzied ready substate
	 * machine. SSP devices do not have a ready substate machine and STP devices
	 * have a ready substate machine.
	 */
	bool has_ready_substate_machine;

	/**
	 * This field contains the state machine for the ready substate machine for
	 * this struct scic_sds_remote_device object.
	 */
	struct sci_base_state_machine ready_substate_machine;

	/**
	 * This field maintains the set of state handlers for the remote device
	 * object.  These are changed each time the remote device enters a new state.
@@ -171,10 +156,6 @@ enum sci_status isci_remote_device_stop(struct isci_host *ihost,
					struct isci_remote_device *idev);
void isci_remote_device_nuke_requests(struct isci_host *ihost,
				      struct isci_remote_device *idev);
void isci_remote_device_ready(struct isci_host *ihost,
			      struct isci_remote_device *idev);
void isci_remote_device_not_ready(struct isci_host *ihost,
				  struct isci_remote_device *idev, u32 reason);
void isci_remote_device_gone(struct domain_device *domain_dev);
int isci_remote_device_found(struct domain_device *domain_dev);
bool isci_device_is_reset_pending(struct isci_host *ihost,
@@ -277,77 +258,6 @@ enum scic_sds_remote_device_states {
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_READY,

	/**
	 * This state indicates that the remote device is in the process of
	 * stopping.  In this state no new IO operations are permitted, but
	 * existing IO operations are allowed to complete.
	 * This state is entered from the READY state.
	 * This state is entered from the FAILED state.
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_STOPPING,

	/**
	 * This state indicates that the remote device has failed.
	 * In this state no new IO operations are permitted.
	 * This state is entered from the INITIALIZING state.
	 * This state is entered from the READY state.
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_FAILED,

	/**
	 * This state indicates the device is being reset.
	 * In this state no new IO operations are permitted.
	 * This state is entered from the READY state.
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_RESETTING,

	/**
	 * Simply the final state for the base remote device state machine.
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_FINAL,
};

/**
 * enum scic_sds_ssp_remote_device_ready_substates -
 *
 * This is the enumeration of the ready substates for the
 * struct scic_sds_remote_device.
 */
enum scic_sds_ssp_remote_device_ready_substates {
	/**
	 * This is the initial state for the remote device ready substate.
	 */
	SCIC_SDS_SSP_REMOTE_DEVICE_READY_SUBSTATE_INITIAL,

	/**
	 * This is the ready operational substate for the remote device.
	 * This is the normal operational state for a remote device.
	 */
	SCIC_SDS_SSP_REMOTE_DEVICE_READY_SUBSTATE_OPERATIONAL,

	/**
	 * This is the suspended state for the remote device. This is the state
	 * that the device is placed in when a RNC suspend is received by
	 * the SCU hardware.
	 */
	SCIC_SDS_SSP_REMOTE_DEVICE_READY_SUBSTATE_SUSPENDED,

	/**
	 * This is the final state that the device is placed in before a change
	 * to the base state machine.
	 */
	SCIC_SDS_SSP_REMOTE_DEVICE_READY_SUBSTATE_FINAL,

	SCIC_SDS_SSP_REMOTE_DEVICE_READY_MAX_SUBSTATES
};

/**
 * enum scic_sds_stp_remote_device_ready_substates -
 *
 * This is the enumeration for the struct scic_sds_remote_device ready substates
 * for the STP remote device.
 */
enum scic_sds_stp_remote_device_ready_substates {
	/**
	 * This is the idle substate for the stp remote device.  When there are no
	 * active IO for the device it is is in this state.
@@ -381,14 +291,7 @@ enum scic_sds_stp_remote_device_ready_substates {
	 * coming to be recovered from certain hardware specific error.
	 */
	SCIC_SDS_STP_REMOTE_DEVICE_READY_SUBSTATE_AWAIT_RESET,
};

/**
 * enum scic_sds_smp_remote_device_ready_substates -
 *
 * This is the enumeration of the ready substates for the SMP REMOTE DEVICE.
 */
enum scic_sds_smp_remote_device_ready_substates {
	/**
	 * This is the ready operational substate for the remote device.  This is the
	 * normal operational state for a remote device.
@@ -400,6 +303,35 @@ enum scic_sds_smp_remote_device_ready_substates {
	 * the device is placed in when a RNC suspend is received by the SCU hardware.
	 */
	SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_CMD,

	/**
	 * This state indicates that the remote device is in the process of
	 * stopping.  In this state no new IO operations are permitted, but
	 * existing IO operations are allowed to complete.
	 * This state is entered from the READY state.
	 * This state is entered from the FAILED state.
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_STOPPING,

	/**
	 * This state indicates that the remote device has failed.
	 * In this state no new IO operations are permitted.
	 * This state is entered from the INITIALIZING state.
	 * This state is entered from the READY state.
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_FAILED,

	/**
	 * This state indicates the device is being reset.
	 * In this state no new IO operations are permitted.
	 * This state is entered from the READY state.
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_RESETTING,

	/**
	 * Simply the final state for the base remote device state machine.
	 */
	SCI_BASE_REMOTE_DEVICE_STATE_FINAL,
};

static inline struct scic_sds_remote_device *rnc_to_dev(struct scic_sds_remote_node_context *rnc)
@@ -541,10 +473,6 @@ struct scic_sds_remote_device_state_handler {
	scic_sds_remote_device_frame_handler_t frame_handler;
};

extern const struct sci_base_state scic_sds_ssp_remote_device_ready_substate_table[];
extern const struct sci_base_state scic_sds_stp_remote_device_ready_substate_table[];
extern const struct sci_base_state scic_sds_smp_remote_device_ready_substate_table[];

/**
 * scic_sds_remote_device_increment_request_count() -
 *
@@ -672,92 +600,24 @@ enum sci_status scic_sds_remote_device_start_io(
	struct scic_sds_remote_device *sci_dev,
	struct scic_sds_request *io_request);

enum sci_status scic_sds_remote_device_complete_io(
enum sci_status scic_sds_remote_device_start_task(
	struct scic_sds_controller *controller,
	struct scic_sds_remote_device *sci_dev,
	struct scic_sds_request *io_request);

enum sci_status scic_sds_remote_device_resume(
	struct scic_sds_remote_device *sci_dev);
enum sci_status scic_sds_remote_device_complete_io(
	struct scic_sds_controller *controller,
	struct scic_sds_remote_device *sci_dev,
	struct scic_sds_request *io_request);

enum sci_status scic_sds_remote_device_suspend(
	struct scic_sds_remote_device *sci_dev,
	u32 suspend_type);

enum sci_status scic_sds_remote_device_start_task(
	struct scic_sds_controller *controller,
	struct scic_sds_remote_device *sci_dev,
	struct scic_sds_request *io_request);

void scic_sds_remote_device_post_request(
	struct scic_sds_remote_device *sci_dev,
	u32 request);

#define scic_sds_remote_device_is_atapi(sci_dev) false

void scic_sds_remote_device_start_request(
	struct scic_sds_remote_device *sci_dev,
	struct scic_sds_request *sci_req,
	enum sci_status status);

void scic_sds_remote_device_continue_request(void *sci_dev);

enum sci_status scic_sds_remote_device_default_start_handler(
	struct scic_sds_remote_device *sci_dev);

enum sci_status scic_sds_remote_device_default_fail_handler(
	struct scic_sds_remote_device *sci_dev);

enum sci_status scic_sds_remote_device_default_destruct_handler(
	struct scic_sds_remote_device *sci_dev);

enum sci_status scic_sds_remote_device_default_reset_handler(
	struct scic_sds_remote_device *device);

enum sci_status scic_sds_remote_device_default_reset_complete_handler(
	struct scic_sds_remote_device *device);

enum sci_status scic_sds_remote_device_default_start_request_handler(
	struct scic_sds_remote_device *device,
	struct scic_sds_request *request);

enum sci_status scic_sds_remote_device_default_complete_request_handler(
	struct scic_sds_remote_device *device,
	struct scic_sds_request *request);

enum sci_status scic_sds_remote_device_default_continue_request_handler(
	struct scic_sds_remote_device *device,
	struct scic_sds_request *request);

enum sci_status scic_sds_remote_device_default_suspend_handler(
	struct scic_sds_remote_device *sci_dev,
	u32 suspend_type);

enum sci_status scic_sds_remote_device_default_resume_handler(
	struct scic_sds_remote_device *sci_dev);


enum sci_status scic_sds_remote_device_default_frame_handler(
	struct scic_sds_remote_device *sci_dev,
	u32 frame_index);

enum sci_status scic_sds_remote_device_ready_state_stop_handler(
	struct scic_sds_remote_device *device);

enum sci_status scic_sds_remote_device_ready_state_reset_handler(
	struct scic_sds_remote_device *device);

enum sci_status scic_sds_remote_device_general_frame_handler(
	struct scic_sds_remote_device *sci_dev,
	u32 frame_index);

enum sci_status scic_sds_remote_device_general_event_handler(
	struct scic_sds_remote_device *sci_dev,
	u32 event_code);

enum sci_status scic_sds_ssp_remote_device_ready_suspended_substate_resume_handler(
	struct scic_sds_remote_device *sci_dev);



#endif /* !defined(_ISCI_REMOTE_DEVICE_H_) */
+0 −310
Original line number Diff line number Diff line
/*
 * This file is provided under a dual BSD/GPLv2 license.  When using or
 * redistributing this file, you may do so under either license.
 *
 * GPL LICENSE SUMMARY
 *
 * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
 * published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
 * The full GNU General Public License is included in this distribution
 * in the file called LICENSE.GPL.
 *
 * BSD LICENSE
 *
 * Copyright(c) 2008 - 2011 Intel Corporation. All rights reserved.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 *   * Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 *   * Redistributions in binary form must reproduce the above copyright
 *     notice, this list of conditions and the following disclaimer in
 *     the documentation and/or other materials provided with the
 *     distribution.
 *   * Neither the name of Intel Corporation nor the names of its
 *     contributors may be used to endorse or promote products derived
 *     from this software without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */

#include "scic_sds_controller.h"
#include "scic_sds_port.h"
#include "remote_device.h"
#include "scic_sds_request.h"
#include "sci_environment.h"
#include "sci_util.h"
#include "scu_event_codes.h"
#include "scu_task_context.h"

/*
 * *****************************************************************************
 * *  SMP REMOTE DEVICE READY IDLE SUBSTATE HANDLERS
 * ***************************************************************************** */

/**
 *
 * @[in]: device The device the io is sent to.
 * @[in]: request The io to start.
 *
 * This method will handle the start io operation for a SMP device that is in
 * the idle state. enum sci_status
 */
static enum sci_status scic_sds_smp_remote_device_ready_idle_substate_start_io_handler(
	struct scic_sds_remote_device *device,
	struct scic_sds_request *request)
{
	enum sci_status status;

	/* Will the port allow the io request to start? */
	status = device->owning_port->state_handlers->start_io_handler(
			device->owning_port, device, request);

	if (status == SCI_SUCCESS) {
		status = scic_sds_remote_node_context_start_io(&device->rnc, request);

		if (status == SCI_SUCCESS)
			status = scic_sds_request_start(request);

		if (status == SCI_SUCCESS) {
			device->working_request = request;

			sci_base_state_machine_change_state(
				&device->ready_substate_machine,
				SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_CMD
				);
		}

		scic_sds_remote_device_start_request(device, request, status);
	}

	return status;
}


/*
 * ******************************************************************************
 * * SMP REMOTE DEVICE READY SUBSTATE CMD HANDLERS
 * ****************************************************************************** */
/**
 *
 * @device: This is the device object that is receiving the IO.
 * @request: The io to start.
 *
 * This device is already handling a command it can not accept new commands
 * until this one is complete. enum sci_status
 */
static enum sci_status scic_sds_smp_remote_device_ready_cmd_substate_start_io_handler(
	struct scic_sds_remote_device *device,
	struct scic_sds_request *request)
{
	return SCI_FAILURE_INVALID_STATE;
}


/**
 * this is the complete_io_handler for smp device at ready cmd substate.
 * @device: This is the device object that is receiving the IO.
 * @request: The io to start.
 *
 * enum sci_status
 */
static enum sci_status
scic_sds_smp_remote_device_ready_cmd_substate_complete_io_handler(
	struct scic_sds_remote_device *device,
	struct scic_sds_request *request)
{
	enum sci_status status;
	struct scic_sds_request *sci_req;

	sci_req = (struct scic_sds_request *)request;

	status = scic_sds_io_request_complete(sci_req);

	if (status == SCI_SUCCESS) {
		status = scic_sds_port_complete_io(
			device->owning_port, device, sci_req);

		if (status == SCI_SUCCESS) {
			scic_sds_remote_device_decrement_request_count(device);
			sci_base_state_machine_change_state(
				&device->ready_substate_machine,
				SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_IDLE
				);
		} else
			dev_err(scirdev_to_dev(device),
				"%s: SCIC SDS Remote Device 0x%p io request "
				"0x%p could not be completd on the port 0x%p "
				"failed with status %d.\n",
				__func__,
				device,
				sci_req,
				device->owning_port,
				status);
	}

	return status;
}

/**
 * This is frame handler for smp device ready cmd substate.
 * @sci_dev: This is the device object that is receiving the frame.
 * @frame_index: The index for the frame received.
 *
 * enum sci_status
 */
static enum sci_status scic_sds_smp_remote_device_ready_cmd_substate_frame_handler(
	struct scic_sds_remote_device *sci_dev,
	u32 frame_index)
{
	enum sci_status status;

	/*
	 * / The device does not process any UF received from the hardware while
	 * / in this state.  All unsolicited frames are forwarded to the io request
	 * / object. */
	status = scic_sds_io_request_frame_handler(
		sci_dev->working_request,
		frame_index
		);

	return status;
}

/* --------------------------------------------------------------------------- */

static const struct scic_sds_remote_device_state_handler scic_sds_smp_remote_device_ready_substate_handler_table[] = {
	[SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_IDLE] = {
		.start_handler		= scic_sds_remote_device_default_start_handler,
		.stop_handler		= scic_sds_remote_device_ready_state_stop_handler,
		.fail_handler		= scic_sds_remote_device_default_fail_handler,
		.destruct_handler	= scic_sds_remote_device_default_destruct_handler,
		.reset_handler		= scic_sds_remote_device_default_reset_handler,
		.reset_complete_handler	= scic_sds_remote_device_default_reset_complete_handler,
		.start_io_handler	= scic_sds_smp_remote_device_ready_idle_substate_start_io_handler,
		.complete_io_handler	= scic_sds_remote_device_default_complete_request_handler,
		.continue_io_handler	= scic_sds_remote_device_default_continue_request_handler,
		.start_task_handler	= scic_sds_remote_device_default_start_request_handler,
		.complete_task_handler	= scic_sds_remote_device_default_complete_request_handler,
		.suspend_handler	= scic_sds_remote_device_default_suspend_handler,
		.resume_handler		= scic_sds_remote_device_default_resume_handler,
		.event_handler		= scic_sds_remote_device_general_event_handler,
		.frame_handler		= scic_sds_remote_device_default_frame_handler
	},
	[SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_CMD] = {
		.start_handler		= scic_sds_remote_device_default_start_handler,
		.stop_handler		= scic_sds_remote_device_ready_state_stop_handler,
		.fail_handler		= scic_sds_remote_device_default_fail_handler,
		.destruct_handler	= scic_sds_remote_device_default_destruct_handler,
		.reset_handler		= scic_sds_remote_device_default_reset_handler,
		.reset_complete_handler	= scic_sds_remote_device_default_reset_complete_handler,
		.start_io_handler	= scic_sds_smp_remote_device_ready_cmd_substate_start_io_handler,
		.complete_io_handler	= scic_sds_smp_remote_device_ready_cmd_substate_complete_io_handler,
		.continue_io_handler	= scic_sds_remote_device_default_continue_request_handler,
		.start_task_handler	= scic_sds_remote_device_default_start_request_handler,
		.complete_task_handler	= scic_sds_remote_device_default_complete_request_handler,
		.suspend_handler	= scic_sds_remote_device_default_suspend_handler,
		.resume_handler		= scic_sds_remote_device_default_resume_handler,
		.event_handler		= scic_sds_remote_device_general_event_handler,
		.frame_handler		= scic_sds_smp_remote_device_ready_cmd_substate_frame_handler
	}
};

/**
 *
 * @object: This is the object which is cast into a
 *    struct scic_sds_remote_device.
 *
 * This is the SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_IDLE enter method.
 * This function sets the ready cmd substate handlers and reports the device as
 * ready. none
 */
static void scic_sds_smp_remote_device_ready_idle_substate_enter(void *object)
{
	struct scic_sds_remote_device *sci_dev = object;
	struct scic_sds_controller *scic = scic_sds_remote_device_get_controller(sci_dev);
	struct isci_host *ihost = scic->ihost;
	struct isci_remote_device *idev = sci_dev_to_idev(sci_dev);

	SET_STATE_HANDLER(sci_dev,
			  scic_sds_smp_remote_device_ready_substate_handler_table,
			  SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_IDLE);

	isci_remote_device_ready(ihost, idev);
}

/**
 *
 * @object: This is the object which is cast into a
 *    struct scic_sds_remote_device.
 *
 * This is the SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_CMD enter method. This
 * function sets the remote device objects ready cmd substate handlers, and
 * notify core user that the device is not ready. none
 */
static void scic_sds_smp_remote_device_ready_cmd_substate_enter(void *object)
{
	struct scic_sds_remote_device *sci_dev = object;
	struct scic_sds_controller *scic = scic_sds_remote_device_get_controller(sci_dev);
	struct isci_host *ihost = scic->ihost;
	struct isci_remote_device *idev = sci_dev_to_idev(sci_dev);

	BUG_ON(sci_dev->working_request == NULL);

	SET_STATE_HANDLER(sci_dev,
			  scic_sds_smp_remote_device_ready_substate_handler_table,
			  SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_CMD);

	isci_remote_device_not_ready(ihost, idev,
				     SCIC_REMOTE_DEVICE_NOT_READY_SMP_REQUEST_STARTED);
}

/**
 *
 * @object: This is the object which is cast into a
 *    struct scic_sds_remote_device.
 *
 * This is the SCIC_SDS_SSP_REMOTE_DEVICE_READY_SUBSTATE_CMD exit method. none
 */
static void scic_sds_smp_remote_device_ready_cmd_substate_exit(void *object)
{
	struct scic_sds_remote_device *sci_dev = object;
	sci_dev->working_request = NULL;
}

/* --------------------------------------------------------------------------- */

const struct sci_base_state scic_sds_smp_remote_device_ready_substate_table[] = {
	[SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_IDLE] = {
		.enter_state = scic_sds_smp_remote_device_ready_idle_substate_enter,
	},
	[SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_CMD] = {
		.enter_state = scic_sds_smp_remote_device_ready_cmd_substate_enter,
		.exit_state  = scic_sds_smp_remote_device_ready_cmd_substate_exit,
	},
};
+0 −716

File deleted.

Preview size limit exceeded, changes collapsed.