Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aaa60fa7 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: cyttsp - remove useless checks in cyttsp_probe() 



This fixes reference-before-check problem; there is no reason to check
if caller passed NULL dev or bus_ops as it is done only by bus-specific
drivers which already do the right thing.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent aa87512f

drivers/input/touchscreen/cyttsp_core.c

+1 −1
Original line number Diff line number Diff line
@@ -523,7 +523,7 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops, 
	struct input_dev *input_dev;

	int error;



	if (!dev || !bus_ops || !pdata || !pdata->name || irq <= 0) {

	if (!pdata || !pdata->name || irq <= 0) {

		error = -EINVAL;

		goto err_out;

	}