Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa9ea6f4 authored by Daniel Rosenberg's avatar Daniel Rosenberg
Browse files

ANDROID: sdcardfs: Remove uninformative prints 



At best these prints do not provide useful information, and
at worst, some allow userspace to abuse the kernel log.

Signed-off-by: default avatarDaniel Rosenberg <drosen@google.com>
Bug: 36138424
Change-Id: I812c57cc6a22b37262935ab77f48f3af4c36827e
parent 7b51da1d

fs/sdcardfs/derived_perm.c

+0 −1
Original line number Diff line number Diff line
@@ -440,7 +440,6 @@ int setup_obb_dentry(struct dentry *dentry, struct path *lower_path) 


	if(!err) {

		/* the obbpath base has been found */

		printk(KERN_INFO "sdcardfs: the sbi->obbpath is found\n");

		pathcpy(lower_path, &obbpath);

	} else {

		/* if the sbi->obbpath is not available, we can optionally

fs/sdcardfs/file.c

+0 −3
Original line number Diff line number Diff line
@@ -217,9 +217,6 @@ static int sdcardfs_open(struct inode *inode, struct file *file) 
	}



	if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name)) {

		printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

                         "	dentry: %s, task:%s\n",

						 __func__, dentry->d_name.name, current->comm);

		err = -EACCES;

		goto out_err;

	}

fs/sdcardfs/inode.c

+1 −23
Original line number Diff line number Diff line
@@ -68,9 +68,6 @@ static int sdcardfs_create(struct inode *dir, struct dentry *dentry, 
	struct fs_struct *copied_fs;



	if (!check_caller_access_to_name(dir, &dentry->d_name)) {

		printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

						 "  dentry: %s, task:%s\n",

						 __func__, dentry->d_name.name, current->comm);

		err = -EACCES;

		goto out_eacces;

	}
@@ -170,9 +167,6 @@ static int sdcardfs_unlink(struct inode *dir, struct dentry *dentry) 
	const struct cred *saved_cred = NULL;



	if (!check_caller_access_to_name(dir, &dentry->d_name)) {

		printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

						 "  dentry: %s, task:%s\n",

						 __func__, dentry->d_name.name, current->comm);

		err = -EACCES;

		goto out_eacces;

	}
@@ -280,9 +274,6 @@ static int sdcardfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode 
	struct qstr q_data = QSTR_LITERAL("data");



	if (!check_caller_access_to_name(dir, &dentry->d_name)) {

		printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

						 "  dentry: %s, task:%s\n",

						 __func__, dentry->d_name.name, current->comm);

		err = -EACCES;

		goto out_eacces;

	}
@@ -392,9 +383,6 @@ static int sdcardfs_rmdir(struct inode *dir, struct dentry *dentry) 
	const struct cred *saved_cred = NULL;



	if (!check_caller_access_to_name(dir, &dentry->d_name)) {

		printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

						 "  dentry: %s, task:%s\n",

						 __func__, dentry->d_name.name, current->comm);

		err = -EACCES;

		goto out_eacces;

	}
@@ -485,9 +473,6 @@ static int sdcardfs_rename(struct inode *old_dir, struct dentry *old_dentry, 


	if (!check_caller_access_to_name(old_dir, &old_dentry->d_name) ||

		!check_caller_access_to_name(new_dir, &new_dentry->d_name)) {

		printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

						 "  new_dentry: %s, task:%s\n",

						 __func__, new_dentry->d_name.name, current->comm);

		err = -EACCES;

		goto out_eacces;

	}
@@ -755,12 +740,8 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct 
	if (!err) {

		/* check the Android group ID */

		parent = dget_parent(dentry);

		if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name)) {

			printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

							 "  dentry: %s, task:%s\n",

							 __func__, dentry->d_name.name, current->comm);

		if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name))

			err = -EACCES;

		}

		dput(parent);

	}
@@ -872,9 +853,6 @@ static int sdcardfs_getattr(struct vfsmount *mnt, struct dentry *dentry, 


	parent = dget_parent(dentry);

	if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name)) {

		printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

						 "  dentry: %s, task:%s\n",

						 __func__, dentry->d_name.name, current->comm);

		dput(parent);

		return -EACCES;

	}

fs/sdcardfs/lookup.c

+0 −3
Original line number Diff line number Diff line
@@ -395,9 +395,6 @@ struct dentry *sdcardfs_lookup(struct inode *dir, struct dentry *dentry, 


	if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name)) {

		ret = ERR_PTR(-EACCES);

		printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"

                         "	dentry: %s, task:%s\n",

						 __func__, dentry->d_name.name, current->comm);

		goto out_err;

        }