Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa879fff authored by Joerg Roedel's avatar Joerg Roedel
Browse files

x86/amd-iommu: Fix device table write order



The V bit of the device table entry has to be set after the
rest of the entry is written to not confuse the hardware.

Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
parent 0feae533
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -1087,9 +1087,9 @@ static void __attach_device(struct amd_iommu *iommu,
	pte_root |= IOMMU_PTE_IR | IOMMU_PTE_IW | IOMMU_PTE_P | IOMMU_PTE_TV;

	write_lock_irqsave(&amd_iommu_devtable_lock, flags);
	amd_iommu_dev_table[devid].data[0] = lower_32_bits(pte_root);
	amd_iommu_dev_table[devid].data[1] = upper_32_bits(pte_root);
	amd_iommu_dev_table[devid].data[2] = domain->id;
	amd_iommu_dev_table[devid].data[1] = upper_32_bits(pte_root);
	amd_iommu_dev_table[devid].data[0] = lower_32_bits(pte_root);

	amd_iommu_pd_table[devid] = domain;
	write_unlock_irqrestore(&amd_iommu_devtable_lock, flags);