Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa851193 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: max8998: Remove wrong set_suspend_[en|dis]able callback settings 



Using the same ops for both [en|dis]able and set_suspend_[en|dis]able
callbacks is actively broken. This patch removes .set_suspend_disable and
.set_suspend_enable callback setting.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent b1a397dc

drivers/regulator/max8998.c

+0 −6
Original line number Diff line number Diff line
@@ -460,8 +460,6 @@ static struct regulator_ops max8998_ldo_ops = { 
	.disable		= max8998_ldo_disable,

	.get_voltage_sel	= max8998_get_voltage_sel,

	.set_voltage_sel	= max8998_set_voltage_ldo_sel,

	.set_suspend_enable	= max8998_ldo_enable,

	.set_suspend_disable	= max8998_ldo_disable,

};



static struct regulator_ops max8998_buck_ops = {
@@ -473,16 +471,12 @@ static struct regulator_ops max8998_buck_ops = { 
	.get_voltage_sel	= max8998_get_voltage_sel,

	.set_voltage_sel	= max8998_set_voltage_buck_sel,

	.set_voltage_time_sel	= max8998_set_voltage_buck_time_sel,

	.set_suspend_enable	= max8998_ldo_enable,

	.set_suspend_disable	= max8998_ldo_disable,

};



static struct regulator_ops max8998_others_ops = {

	.is_enabled		= max8998_ldo_is_enabled,

	.enable			= max8998_ldo_enable,

	.disable		= max8998_ldo_disable,

	.set_suspend_enable	= max8998_ldo_enable,

	.set_suspend_disable	= max8998_ldo_disable,

};



static struct regulator_desc regulators[] = {