Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa61a893 authored by Konstantin Dorfman's avatar Konstantin Dorfman Committed by Gerrit - the friendly Code Review server
Browse files

soc: qcom: spcom: fix NULL pointer dereference 



This change fix kernel panic due to NULL pointer dereference from
spcom_probe while unregister the device. Observed during kernel testing
(bind/unbind of platform driver).

Change-Id: I5ead40d9da25e9ca2a59af9ba8c236d575103eae
Signed-off-by: default avatarKonstantin Dorfman <kdorfman@codeaurora.org>
parent b93572a7

drivers/soc/qcom/spcom.c

+2 −1
Original line number Diff line number Diff line
@@ -2086,7 +2086,7 @@ static int spcom_probe(struct platform_device *pdev) 
	ret = spcom_register_chardev();

	if (ret) {

		pr_err("create character device failed.\n");

		goto fail_reg_chardev;

		goto fail_while_chardev_reg;

	}



	ret = spcom_parse_dt(np);
@@ -2104,6 +2104,7 @@ static int spcom_probe(struct platform_device *pdev) 
fail_reg_chardev:

	pr_err("failed to init driver\n");

	spcom_unregister_chrdev();

fail_while_chardev_reg:

	kfree(dev);

	spcom_dev = NULL;