Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a95a0381 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: misc: phidgetmotorcontrol: clean up urb->status usage 



This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 2fe8c3f1

drivers/usb/misc/phidgetmotorcontrol.c

+7 −6
Original line number Diff line number Diff line
@@ -95,9 +95,10 @@ static void motorcontrol_irq(struct urb *urb) 
	struct motorcontrol *mc = urb->context;

	unsigned char *buffer = mc->data;

	int i, level;

	int status;

	int retval;

	int status = urb->status;;



	switch (urb->status) {

	switch (status) {

	case 0:			/* success */

		break;

	case -ECONNRESET:	/* unlink */
@@ -151,12 +152,12 @@ static void motorcontrol_irq(struct urb *urb) 
		schedule_delayed_work(&mc->do_notify, 0);



resubmit:

	status = usb_submit_urb(urb, GFP_ATOMIC);

	if (status)

	retval = usb_submit_urb(urb, GFP_ATOMIC);

	if (retval)

		dev_err(&mc->intf->dev,

			"can't resubmit intr, %s-%s/motorcontrol0, status %d",

			"can't resubmit intr, %s-%s/motorcontrol0, retval %d",

			mc->udev->bus->bus_name,

			mc->udev->devpath, status);

			mc->udev->devpath, retval);

}



static void do_notify(struct work_struct *work)