Commit a858d64b authored Jul 17, 2012 by Li Wei Committed by David S. Miller Jul 17, 2012

ipv6: fix unappropriate errno returned for non-multicast address



We need to check the passed in multicast address and return
appropriate errno(EINVAL) if it is not valid. And it's no need
to walk through the ipv6_mc_list in this situation.

Signed-off-by: Li Wei <lw@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c41e4130

net/ipv6/mcast.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -211,6 +211,9 @@ int ipv6_sock_mc_drop(struct sock sk, int ifindex, const struct in6_addr addr)
		struct ipv6_mc_socklist __rcu **lnk;
		struct net *net = sock_net(sk);

		if (!ipv6_addr_is_multicast(addr))
		return -EINVAL;

		spin_lock(&ipv6_sk_mc_lock);
		for (lnk = &np->ipv6_mc_list;
		(mc_lst = rcu_dereference_protected(*lnk,