Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7ed07d5 authored by Richard Zhao's avatar Richard Zhao Committed by David S. Miller
Browse files

net: fec: correct phy_name buffer length when init phy_name 



Fix the bug that we got wrong phy_name on imx6q sabrelite board.
snprintf used wrong length of phy_name.
phy_name length is MII_BUS_ID_SIZE + 3 rather not MII_BUS_ID_SIZE.
I change it to sizeof(phy_name).

Signed-off-by: default avatarRichard Zhao <richard.zhao@linaro.org>
Acked-by: default avatarShawn Guo <shawn.guo@linaro.org>
Acked-by: default avatarFlorian Fainelli <florian@openwrt.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d3712b9d

drivers/net/ethernet/freescale/fec.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -990,7 +990,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) 
		phy_id = 0;

		phy_id = 0;

	}

	}





	snprintf(phy_name, MII_BUS_ID_SIZE, PHY_ID_FMT, mdio_bus_id, phy_id);

	snprintf(phy_name, sizeof(phy_name), PHY_ID_FMT, mdio_bus_id, phy_id);

	phy_dev = phy_connect(ndev, phy_name, &fec_enet_adjust_link, 0,

	phy_dev = phy_connect(ndev, phy_name, &fec_enet_adjust_link, 0,

			      fep->phy_interface);

			      fep->phy_interface);

	if (IS_ERR(phy_dev)) {

	if (IS_ERR(phy_dev)) {