Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a72d2abb authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: tlv320aic31xx: Do not ignore errors in aic31xx_device_init() 



We need to return the error codes from aic31xx_device_init() and return
from the i2c_probe with the error code.
We will have kernel panic (NULL pointer dereference) in
regulator_register_notifier() in case the devm_regulator_bulk_get() fails
(with -EPROBE_DEFER for example).

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
Cc: stable@vger.kernel.org
parent 7171511e

sound/soc/codecs/tlv320aic31xx.c

+6 −3
Original line number Diff line number Diff line
@@ -1178,7 +1178,7 @@ static void aic31xx_pdata_from_of(struct aic31xx_priv *aic31xx) 
}

#endif /* CONFIG_OF */



static void aic31xx_device_init(struct aic31xx_priv *aic31xx)

static int aic31xx_device_init(struct aic31xx_priv *aic31xx)

{

	int ret, i;
@@ -1197,7 +1197,7 @@ static void aic31xx_device_init(struct aic31xx_priv *aic31xx) 
					    "aic31xx-reset-pin");

		if (ret < 0) {

			dev_err(aic31xx->dev, "not able to acquire gpio\n");

			return;

			return ret;

		}

	}
@@ -1210,6 +1210,7 @@ static void aic31xx_device_init(struct aic31xx_priv *aic31xx) 
	if (ret != 0)

		dev_err(aic31xx->dev, "Failed to request supplies: %d\n", ret);



	return ret;

}



static int aic31xx_i2c_probe(struct i2c_client *i2c,
@@ -1239,7 +1240,9 @@ static int aic31xx_i2c_probe(struct i2c_client *i2c, 


	aic31xx->pdata.codec_type = id->driver_data;



	aic31xx_device_init(aic31xx);

	ret = aic31xx_device_init(aic31xx);

	if (ret)

		return ret;



	return snd_soc_register_codec(&i2c->dev, &soc_codec_driver_aic31xx,

				     aic31xx_dai_driver,