Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a63c580a authored Jul 29, 2015 by Oded Gabbay

drm/amdkfd: fix bug when initializing sdma vm



A logical AND operation was used during mask and shift, instead of a
bitwise AND operation. This patch fixes this bug by changing the
operation to bitwise AND.

Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

parent e8a64b20

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_cik.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -143,7 +143,7 @@ static void init_sdma_vm(struct device_queue_manager dqm, struct queue q,
		get_sh_mem_bases_32(qpd_to_pdd(qpd));
		else
		value \|= ((get_sh_mem_bases_nybble_64(qpd_to_pdd(qpd))) <<
		SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE__SHIFT) &&
		SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE__SHIFT) &
		SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE_MASK;

		q->properties.sdma_vm_addr = value;

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -155,7 +155,7 @@ static void init_sdma_vm(struct device_queue_manager dqm, struct queue q,
		get_sh_mem_bases_32(qpd_to_pdd(qpd));
		else
		value \|= ((get_sh_mem_bases_nybble_64(qpd_to_pdd(qpd))) <<
		SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE__SHIFT) &&
		SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE__SHIFT) &
		SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE_MASK;

		q->properties.sdma_vm_addr = value;