Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6196bab authored by Thomas Meyer's avatar Thomas Meyer Committed by Ralf Baechle
Browse files

MIPS: Alchemy: Use kmemdup rather than duplicating its implementation 



The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/3058/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent a551fafb

arch/mips/alchemy/common/platform.c

+4 −6
Original line number Diff line number Diff line
@@ -334,13 +334,12 @@ static void __init alchemy_setup_macs(int ctype) 
	if (alchemy_get_macs(ctype) < 1)

		return;



	macres = kmalloc(sizeof(struct resource) * MAC_RES_COUNT, GFP_KERNEL);

	macres = kmemdup(au1xxx_eth0_resources[ctype],

			 sizeof(struct resource) * MAC_RES_COUNT, GFP_KERNEL);

	if (!macres) {

		printk(KERN_INFO "Alchemy: no memory for MAC0 resources\n");

		return;

	}

	memcpy(macres, au1xxx_eth0_resources[ctype],

	       sizeof(struct resource) * MAC_RES_COUNT);

	au1xxx_eth0_device.resource = macres;



	i = prom_get_ethernet_addr(ethaddr);
@@ -356,13 +355,12 @@ static void __init alchemy_setup_macs(int ctype) 
	if (alchemy_get_macs(ctype) < 2)

		return;



	macres = kmalloc(sizeof(struct resource) * MAC_RES_COUNT, GFP_KERNEL);

	macres = kmemdup(au1xxx_eth1_resources[ctype],

			 sizeof(struct resource) * MAC_RES_COUNT, GFP_KERNEL);

	if (!macres) {

		printk(KERN_INFO "Alchemy: no memory for MAC1 resources\n");

		return;

	}

	memcpy(macres, au1xxx_eth1_resources[ctype],

	       sizeof(struct resource) * MAC_RES_COUNT);

	au1xxx_eth1_device.resource = macres;



	ethaddr[5] += 1;	/* next addr for 2nd MAC */