Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4b54acf authored by Russell King's avatar Russell King
Browse files

MFD: mcp-sa11x0: complain if mcp clock is left enabled 



Issue a warning if the mcp clock was left enabled by some driver when
we're suspending or tearing down the core driver for the device.  This
is an aid for debugging missing disable calls.

Acked-by: default avatarJochen Friedrich <jochen@scram.de>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 2b4d9d2b

drivers/mfd/mcp-sa11x0.c

+7 −0
Original line number Original line Diff line number Diff line
@@ -252,6 +252,10 @@ static int mcp_sa11x0_remove(struct platform_device *dev) 
	struct mcp_sa11x0 *m = priv(mcp);

	struct mcp_sa11x0 *m = priv(mcp);

	struct resource *mem0, *mem1;

	struct resource *mem0, *mem1;





	if (m->mccr0 & MCCR0_MCE)

		dev_warn(&dev->dev,

			 "device left active (missing disable call?)\n");



	mem0 = platform_get_resource(dev, IORESOURCE_MEM, 0);

	mem0 = platform_get_resource(dev, IORESOURCE_MEM, 0);

	mem1 = platform_get_resource(dev, IORESOURCE_MEM, 1);

	mem1 = platform_get_resource(dev, IORESOURCE_MEM, 1);
@@ -271,6 +275,9 @@ static int mcp_sa11x0_suspend(struct device *dev) 
{

{

	struct mcp_sa11x0 *m = priv(dev_get_drvdata(dev));

	struct mcp_sa11x0 *m = priv(dev_get_drvdata(dev));





	if (m->mccr0 & MCCR0_MCE)

		dev_warn(dev, "device left active (missing disable call?)\n");



	writel(m->mccr0 & ~MCCR0_MCE, MCCR0(m));

	writel(m->mccr0 & ~MCCR0_MCE, MCCR0(m));





	return 0;

	return 0;