Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4906ea0 authored by Sathya Perla's avatar Sathya Perla Committed by David S. Miller
Browse files

be2net: define macro for_all_tx_queues_on_eq() 



Replace the for() loop that traverses all the TX queues on an EQ
with the macro for_all_tx_queues_on_eq(). With this expalnatory
name, the one line comment is not required anymore.

Signed-off-by: default avatarSathya Perla <sathya.perla@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c8f64615

drivers/net/ethernet/emulex/benet/be.h

+4 −0
Original line number Diff line number Diff line
@@ -621,6 +621,10 @@ extern const struct ethtool_ops be_ethtool_ops; 
	for (i = eqo->idx, rxo = &adapter->rx_obj[i]; i < adapter->num_rx_qs;\

		 i += adapter->num_evt_qs, rxo += adapter->num_evt_qs)



#define for_all_tx_queues_on_eq(adapter, eqo, txo, i)			\

	for (i = eqo->idx, txo = &adapter->tx_obj[i]; i < adapter->num_tx_qs;\

		i += adapter->num_evt_qs, txo += adapter->num_evt_qs)



#define is_mcc_eqo(eqo)			(eqo->idx == 0)

#define mcc_eqo(adapter)		(&adapter->eq_obj[0])

drivers/net/ethernet/emulex/benet/be_main.c

+3 −3
Original line number Diff line number Diff line
@@ -2503,12 +2503,12 @@ int be_poll(struct napi_struct *napi, int budget) 
	struct be_adapter *adapter = eqo->adapter;

	int max_work = 0, work, i, num_evts;

	struct be_rx_obj *rxo;

	struct be_tx_obj *txo;



	num_evts = events_get(eqo);



	/* Process all TXQs serviced by this EQ */

	for (i = eqo->idx; i < adapter->num_tx_qs; i += adapter->num_evt_qs)

		be_process_tx(adapter, &adapter->tx_obj[i], i);

	for_all_tx_queues_on_eq(adapter, eqo, txo, i)

		be_process_tx(adapter, txo, i);



	if (be_lock_napi(eqo)) {

		/* This loop will iterate twice for EQ0 in which