Commit a46fa260 authored Jul 21, 2015 by Dan Murphy Committed by David S. Miller Jul 21, 2015

net: phy: dp83867: Fix warning check for setting the internal delay



Fix warning: logical ‘or’ of collectively exhaustive tests is always true

Change the internal delay check from an 'or' condition to an 'and'
condition.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bac541e4

drivers/net/phy/dp83867.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -164,7 +164,7 @@ static int dp83867_config_init(struct phy_device *phydev)
		return ret;
		}

		if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) \|\|
		if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
		(phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
		val = phy_read_mmd_indirect(phydev, DP83867_RGMIICTL,
		DP83867_DEVADDR, phydev->addr);