Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a45526bb authored by Markus Elfring's avatar Markus Elfring Committed by Ralf Baechle
Browse files

MIPS: MT: Move an assignment for the variable "retval" in mipsmt_sys_sched_setaffinity() 



A local variable was set to an error code in one case before a concrete
error situation was detected. Thus move the corresponding assignment into
an if branch to indicate a software failure there.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-mips@linux-mips.org
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: kernel-janitors@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/15072/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent fcf4aec1

arch/mips/kernel/mips-mt-fpaff.c

+3 −2
Original line number Diff line number Diff line
@@ -99,9 +99,10 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len, 
		retval = -ENOMEM;

		goto out_free_new_mask;

	}

	if (!check_same_owner(p) && !capable(CAP_SYS_NICE)) {

		retval = -EPERM;

	if (!check_same_owner(p) && !capable(CAP_SYS_NICE))

		goto out_unlock;

	}



	retval = security_task_setscheduler(p);

	if (retval)