Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a406abeb authored by Sean Young's avatar Sean Young Committed by Greg Kroah-Hartman
Browse files

media: rc: oops in ir_timer_keyup after device unplug 



commit 8d4068810d9926250dd2435719a080b889eb44c3 upstream.

If there is IR in the raw kfifo when ir_raw_event_unregister() is called,
then kthread_stop() causes ir_raw_event_thread to be scheduled, decode
some scancodes and re-arm timer_keyup. The timer_keyup then fires when
the rc device is long gone.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: default avatarSudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 67f7c68a

drivers/media/rc/rc-main.c

+2 −2
Original line number Diff line number Diff line
@@ -1824,11 +1824,11 @@ void rc_unregister_device(struct rc_dev *dev) 
	if (!dev)

		return;



	del_timer_sync(&dev->timer_keyup);



	if (dev->driver_type == RC_DRIVER_IR_RAW)

		ir_raw_event_unregister(dev);



	del_timer_sync(&dev->timer_keyup);



	rc_free_rx_device(dev);



	device_del(&dev->dev);