Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a3ff6d56 authored by Damien Lespiau's avatar Damien Lespiau Committed by Daniel Vetter
Browse files

drm: Reject modes with more than 1 stereo flags set 



When setting a stereo 3D mode, there can be only one bit set describing
the layout of the frambuffer(s). So reject invalid modes early.

Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Acked-by: default avatarDave Airlie <airlied@gmail.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 1deee8d7

drivers/gpu/drm/drm_crtc.c

+4 −0
Original line number Diff line number Diff line
@@ -1319,6 +1319,10 @@ static int drm_crtc_convert_umode(struct drm_display_mode *out, 
	if (in->clock > INT_MAX || in->vrefresh > INT_MAX)

		return -ERANGE;



	/* At most, 1 set bit describing the 3D layout of the mode */

	if (hweight32(in->flags & DRM_MODE_FLAG_3D_MASK) > 1)

		return -EINVAL;



	out->clock = in->clock;

	out->hdisplay = in->hdisplay;

	out->hsync_start = in->hsync_start;