Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a3b3a9db authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

ALSA: hdsp: silence a sprinft() overflow warning 



card->shortname is a 32 char string so the sprintf() can theoretically
overflow.  snd_rawmidi_new() can accept strings up to 64 bytes long.

I have made the temporay buf[] array 40 bytes long and changed the
sprintf() to snprintf().

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f09d4f26

sound/pci/rme9652/hdsp.c

+2 −2
Original line number Diff line number Diff line
@@ -1526,7 +1526,7 @@ static struct snd_rawmidi_ops snd_hdsp_midi_input = 


static int snd_hdsp_create_midi (struct snd_card *card, struct hdsp *hdsp, int id)

{

	char buf[32];

	char buf[40];



	hdsp->midi[id].id = id;

	hdsp->midi[id].rmidi = NULL;
@@ -1537,7 +1537,7 @@ static int snd_hdsp_create_midi (struct snd_card *card, struct hdsp *hdsp, int i 
	hdsp->midi[id].pending = 0;

	spin_lock_init (&hdsp->midi[id].lock);



	sprintf (buf, "%s MIDI %d", card->shortname, id+1);

	snprintf(buf, sizeof(buf), "%s MIDI %d", card->shortname, id + 1);

	if (snd_rawmidi_new (card, buf, id, 1, 1, &hdsp->midi[id].rmidi) < 0)

		return -1;