Commit a3478bae authored Mar 13, 2016 by Sergei Shtylyov Committed by David S. Miller Mar 14, 2016

of_mdio: mdio_device_create() never returns NULL



mdio_device_create() never returns NULL, thus checking for it in
of_mdiobus_register_device() is pointless...

Suggested-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1f3a1c54

drivers/of/of_mdio.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -98,7 +98,7 @@ static int of_mdiobus_register_device(struct mii_bus *mdio,
	int rc;		int rc;

	mdiodev = mdio_device_create(mdio, addr);		mdiodev = mdio_device_create(mdio, addr);
	if (!mdiodev \|\| IS_ERR(mdiodev))		if (IS_ERR(mdiodev))
	return 1;		return 1;

	/* Associate the OF node with the device structure so it		/* Associate the OF node with the device structure so it