Commit a1bdc7aa authored Oct 13, 2005 by Ben Dooks Committed by Greg Kroah-Hartman Oct 28, 2005

[PATCH] drivers/base - fix sparse warnings

There are a number of sparse warnings from the latest sparse
snapshot being generated from the drivers/base build. The
main culprits are due to the initialisation functions not
being declared in a header file.

Also, the firmware.c file should include <linux/device.h>
to get the prototype of firmware_register() and
firmware_unregister().

This patch moves the init function declerations from the
init.c file to the base.h, and ensures it is included in
all the relevant c sources. It also adds <linux/device.h>
to the included headers for firmware.c.

The patch does not solve all the sparse errors generated,
but reduces the count significantly.

drivers/base/core.c:161:1: warning: symbol 'devices_subsys' was not declared. Should it be static?
drivers/base/core.c:417:12: warning: symbol 'devices_init' was not declared. Should it be static?
drivers/base/sys.c:253:6: warning: symbol 'sysdev_shutdown' was not declared. Should it be static?
drivers/base/sys.c:326:5: warning: symbol 'sysdev_suspend' was not declared. Should it be static?
drivers/base/sys.c:428:5: warning: symbol 'sysdev_resume' was not declared. Should it be static?
drivers/base/sys.c:450:12: warning: symbol 'system_bus_init' was not declared. Should it be static?
drivers/base/bus.c:133:1: warning: symbol 'bus_subsys' was not declared. Should it be static?
drivers/base/bus.c:667:12: warning: symbol 'buses_init' was not declared. Should it be static?
drivers/base/class.c:759:12: warning: symbol 'classes_init' was not declared. Should it be static?
drivers/base/platform.c:313:12: warning: symbol 'platform_bus_init' was not declared. Should it be static?
drivers/base/cpu.c:110:12: warning: symbol 'cpu_dev_init' was not declared. Should it be static?
drivers/base/firmware.c:17:5: warning: symbol 'firmware_register' was not declared. Should it be static?
drivers/base/firmware.c:23:6: warning: symbol 'firmware_unregister' was not declared. Should it be static?
drivers/base/firmware.c:28:12: warning: symbol 'firmware_init' was not declared. Should it be static?
drivers/base/init.c:28:13: warning: symbol 'driver_init' was not declared. Should it be static?
drivers/base/dmapool.c:174:10: warning: implicit cast from nocast type
drivers/base/attribute_container.c:439:1: warning: symbol 'attribute_container_init' was not declared. Should it be static?
drivers/base/power/runtime.c:76:6: warning: symbol 'dpm_set_power_state' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent a7fadbe1

drivers/base/attribute_container.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -19,6 +19,8 @@
		#include <linux/list.h>
		#include <linux/module.h>

		#include "base.h"

		/* This is a private structure used to tie the classdev and the
		* container .. it should never be visible outside this file */
		struct internal_container {

drivers/base/base.h

+12 −0

Original line number	Diff line number	Diff line

		/* initialisation functions */

		extern int devices_init(void);
		extern int buses_init(void);
		extern int classes_init(void);
		extern int firmware_init(void);
		extern int platform_bus_init(void);
		extern int system_bus_init(void);
		extern int cpu_dev_init(void);
		extern int attribute_container_init(void);

		extern int bus_add_device(struct device * dev);
		extern void bus_remove_device(struct device * dev);

drivers/base/cpu.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -9,6 +9,7 @@
		#include <linux/topology.h>
		#include <linux/device.h>

		#include "base.h"

		struct sysdev_class cpu_sysdev_class = {
		set_kset_name("cpu"),

drivers/base/firmware.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -11,6 +11,9 @@
		#include <linux/kobject.h>
		#include <linux/module.h>
		#include <linux/init.h>
		#include <linux/device.h>

		#include "base.h"

		static decl_subsys(firmware, NULL, NULL);

drivers/base/init.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -10,14 +10,8 @@
		#include <linux/device.h>
		#include <linux/init.h>

		extern int devices_init(void);
		extern int buses_init(void);
		extern int classes_init(void);
		extern int firmware_init(void);
		extern int platform_bus_init(void);
		extern int system_bus_init(void);
		extern int cpu_dev_init(void);
		extern int attribute_container_init(void);
		#include "base.h"

		/**
		* driver_init - initialize driver model.
		*