Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a141a043 authored by Amol Lad's avatar Amol Lad Committed by Linus Torvalds
Browse files

[PATCH] ioremap balanced with iounmap for drivers/serial/mpsc.c 



ioremap must be balanced by an iounmap and failing to do so can result
in a memory leak.

Signed-off-by: default avatarAmol Lad <amol@verismonetworks.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Mark A. Greer <mgreer@mvista.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent be618f55

drivers/serial/mpsc.c

+12 −0
Original line number Diff line number Diff line
@@ -1893,6 +1893,10 @@ mpsc_drv_map_regs(struct mpsc_port_info *pi, struct platform_device *pd) 
	}

	else {

		mpsc_resource_err("SDMA base");

		if (pi->mpsc_base) {

			iounmap(pi->mpsc_base);

			pi->mpsc_base = NULL;

		}

		return -ENOMEM;

	}
@@ -1905,6 +1909,14 @@ mpsc_drv_map_regs(struct mpsc_port_info *pi, struct platform_device *pd) 
	}

	else {

		mpsc_resource_err("BRG base");

		if (pi->mpsc_base) {

			iounmap(pi->mpsc_base);

			pi->mpsc_base = NULL;

		}

		if (pi->sdma_base) {

			iounmap(pi->sdma_base);

			pi->sdma_base = NULL;

		}

		return -ENOMEM;

	}