Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0880094 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Takashi Iwai
Browse files

ASLA: ad1889: Remove always NULL parameter 



snd_ad1889_pcm_init() takes a pointer to a pointer of a PCM where if this
parameter is provided the newly allocated PCM is stored. All callers pass
NULL though, so remove the parameter. This makes the code a bit cleaner and
shorter.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent fa60c065

sound/pci/ad1889.c

+2 −8
Original line number Diff line number Diff line
@@ -623,14 +623,11 @@ snd_ad1889_interrupt(int irq, void *dev_id) 
}



static int

snd_ad1889_pcm_init(struct snd_ad1889 *chip, int device, struct snd_pcm **rpcm)

snd_ad1889_pcm_init(struct snd_ad1889 *chip, int device)

{

	int err;

	struct snd_pcm *pcm;



	if (rpcm)

		*rpcm = NULL;



	err = snd_pcm_new(chip->card, chip->card->driver, device, 1, 1, &pcm);

	if (err < 0)

		return err;
@@ -658,9 +655,6 @@ snd_ad1889_pcm_init(struct snd_ad1889 *chip, int device, struct snd_pcm **rpcm) 
		return err;

	}

	

	if (rpcm)

		*rpcm = pcm;

	

	return 0;

}
@@ -1016,7 +1010,7 @@ snd_ad1889_probe(struct pci_dev *pci, 
	if (err < 0)

		goto free_and_ret;

	

	err = snd_ad1889_pcm_init(chip, 0, NULL);

	err = snd_ad1889_pcm_init(chip, 0);

	if (err < 0)

		goto free_and_ret;