Commit 9f0962c0 authored Sep 28, 2018 by Florian Fainelli Committed by Greg Kroah-Hartman Nov 04, 2018

lan78xx: Check for supported Wake-on-LAN modes



[ Upstream commit eb9ad088f96653a26b340f7c447c44cf023d5cdc ]

The driver supports a fair amount of Wake-on-LAN modes, but is not
checking that the user specified one that is supported.

Fixes: 55d7de9d ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Woojung Huh <Woojung.Huh@Microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a0fc0633

drivers/net/usb/lan78xx.c

+4 −13

Original line number	Diff line number	Diff line
		@@ -1375,19 +1375,10 @@ static int lan78xx_set_wol(struct net_device *netdev,
		if (ret < 0)
		return ret;

		pdata->wol = 0;
		if (wol->wolopts & WAKE_UCAST)
		pdata->wol \|= WAKE_UCAST;
		if (wol->wolopts & WAKE_MCAST)
		pdata->wol \|= WAKE_MCAST;
		if (wol->wolopts & WAKE_BCAST)
		pdata->wol \|= WAKE_BCAST;
		if (wol->wolopts & WAKE_MAGIC)
		pdata->wol \|= WAKE_MAGIC;
		if (wol->wolopts & WAKE_PHY)
		pdata->wol \|= WAKE_PHY;
		if (wol->wolopts & WAKE_ARP)
		pdata->wol \|= WAKE_ARP;
		if (wol->wolopts & ~WAKE_ALL)
		return -EINVAL;

		pdata->wol = wol->wolopts;

		device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts);