Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ec4ff42 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

hpt366: write the full 4 bytes of ROM address, not just low 1 byte 



This is one heck of a confused driver.  It uses a byte write to a dword
register to enable a ROM resource that it doesn't even seem to be using.

"Lost and wandering in the desert of confusion"

Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent aa7c3a11

drivers/ide/pci/hpt366.c

+6 −2
Original line number Original line Diff line number Diff line
@@ -1334,9 +1334,13 @@ static int __devinit init_hpt366(struct pci_dev *dev) 
static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const char *name)

static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const char *name)

{

{

	int ret = 0;

	int ret = 0;

	/* FIXME: Not portable */



	/*

	 * FIXME: Not portable. Also, why do we enable the ROM in the first place?

	 * We don't seem to be using it.

	 */

	if (dev->resource[PCI_ROM_RESOURCE].start)

	if (dev->resource[PCI_ROM_RESOURCE].start)

		pci_write_config_byte(dev, PCI_ROM_ADDRESS,

		pci_write_config_dword(dev, PCI_ROM_ADDRESS,

			dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);

			dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);





	pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE, (L1_CACHE_BYTES / 4));

	pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE, (L1_CACHE_BYTES / 4));