Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e8fa040 authored by Roland Dreier's avatar Roland Dreier
Browse files

RDMA/ocrdma: Fix check of GSI CQs 



It looks like one check was accidentally duplicated, and the other 3
checks were left out.  This was detected by scripts/coccinelle/tests/doubletest.cocci:

    drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:895:6-54: duplicated argument to && or ||

Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 5dedb9f3

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c

+3 −1
Original line number Diff line number Diff line
@@ -893,7 +893,9 @@ static int ocrdma_check_qp_params(struct ib_pd *ibpd, struct ocrdma_dev *dev, 
	/* verify consumer QPs are not trying to use GSI QP's CQ */

	if ((attrs->qp_type != IB_QPT_GSI) && (dev->gsi_qp_created)) {

		if ((dev->gsi_sqcq == get_ocrdma_cq(attrs->send_cq)) ||

		    (dev->gsi_sqcq == get_ocrdma_cq(attrs->send_cq))) {

		    (dev->gsi_sqcq == get_ocrdma_cq(attrs->recv_cq)) ||

		    (dev->gsi_rqcq == get_ocrdma_cq(attrs->send_cq)) ||

		    (dev->gsi_rqcq == get_ocrdma_cq(attrs->recv_cq))) {

			ocrdma_err("%s(%d) Consumer QP cannot use GSI CQs.\n",

				   __func__, dev->id);

			return -EINVAL;