Commit 9e578b37 authored Jul 03, 2017 by Gustavo A. R. Silva Committed by MyungJoo Ham Jul 06, 2017

PM / devfreq: tegra: fix error return code in tegra_devfreq_probe()

platform_get_irq() returns an error code, but the tegra-devfreq
driver ignores it and always returns -ENODEV. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

parent da55b1ad

drivers/devfreq/tegra-devfreq.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
		}

		irq = platform_get_irq(pdev, 0);
		if (irq <= 0) {
		dev_err(&pdev->dev, "Failed to get IRQ\n");
		return -ENODEV;
		if (irq < 0) {
		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
		return irq;
		}

		platform_set_drvdata(pdev, tegra);