Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e303f22 authored by Grazvydas Ignotas's avatar Grazvydas Ignotas Committed by Kevin Hilman
Browse files

gpio/omap: fix irq loss while in idle with debounce on 



It seems that currently GPIO module is not working correctly during idle
when debounce is enabled - the system almost never responds to button
presses (observed on OMAP3530 ES2.1 and OMAP3630 ES1.2 pandora boards).
Even though wakeups are probably working, it seems that the GPIO module
itself is unable to detect input events and generate interrupts.
OMAP35x TRM also states that:
  "If the debounce clock is inactive, the debounce cell gates all
   input signals and thus cannot be used."

So whenever we are disabling debounce clocks (for PM or other reasons),
be sure the module's debounce feature is disabled too.

Cc: Kevin Hilman <khilman@ti.com>
Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
parent 6b16351a

drivers/gpio/gpio-omap.c

+10 −0
Original line number Original line Diff line number Diff line
@@ -174,12 +174,22 @@ static inline void _gpio_dbck_enable(struct gpio_bank *bank) 
	if (bank->dbck_enable_mask && !bank->dbck_enabled) {

	if (bank->dbck_enable_mask && !bank->dbck_enabled) {

		clk_enable(bank->dbck);

		clk_enable(bank->dbck);

		bank->dbck_enabled = true;

		bank->dbck_enabled = true;



		__raw_writel(bank->dbck_enable_mask,

			     bank->base + bank->regs->debounce_en);

	}

	}

}

}





static inline void _gpio_dbck_disable(struct gpio_bank *bank)

static inline void _gpio_dbck_disable(struct gpio_bank *bank)

{

{

	if (bank->dbck_enable_mask && bank->dbck_enabled) {

	if (bank->dbck_enable_mask && bank->dbck_enabled) {

		/*

		 * Disable debounce before cutting it's clock. If debounce is

		 * enabled but the clock is not, GPIO module seems to be unable

		 * to detect events and generate interrupts at least on OMAP3.

		 */

		__raw_writel(0, bank->base + bank->regs->debounce_en);



		clk_disable(bank->dbck);

		clk_disable(bank->dbck);

		bank->dbck_enabled = false;

		bank->dbck_enabled = false;

	}

	}