Commit 9d8757c6 authored Nov 14, 2016 by Greg Hackmann Committed by Amit Pundir Dec 18, 2017

ANDROID: dm: android-verity: fix table_make_digest() error handling



If table_make_digest() fails, verify_verity_signature() would try to
pass the returned ERR_PTR() to kfree().

This fixes the smatch error:

drivers/md/dm-android-verity.c:601 verify_verity_signature() error: 'pks' dereferencing possible ERR_PTR()

Change-Id: I9b9b7764b538cb4a5f94337660e9b0f149b139be
Signed-off-by: Greg Hackmann <ghackmann@google.com>

parent 539de6b3

drivers/md/dm-android-verity.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -585,6 +585,8 @@ static int verify_verity_signature(char *key_id,

		if (IS_ERR(pks)) {
		DMERR("hashing failed");
		retval = PTR_ERR(pks);
		pks = NULL;
		goto error;
		}